ci: run Rust tests on Win/Linux (+ argv test)#208
Open
oratis wants to merge 2 commits into
Open
Conversation
The cross-platform CI job was compile-only. Add `cargo test` so platform- specific logic (argv file-open, the Linux token-file fallback) is exercised where it runs, not just compiled. Also adds a unit test for paths_from_argv (skips argv[0], keeps only existing Markdown files) — it's cfg(win/linux) so it runs in that CI job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C from the autonomous list. The
cross-platformCI job was compile-only; now it runs the Rust suite on Windows + Linux so platform-specific logic is tested where it runs, not just compiled.What
ci.yml: add acargo teststep to thecross-platformmatrix job (renamed → "compile + test").lib.rs: add a unit test forpaths_from_argv— verifies it skipsargv[0], drops non-Markdown and non-existent paths, and keeps the real.md. It'scfg(win/linux)(matching the fn), so it runs in this job. The Linux token-file fallback test also now runs on the Linux runner.Cost note
This adds
cargo testto 2 runners on every PR (~a few min each, cached). If PR CI time matters more, easy to scope topush: [main]only — say the word.Verified: YAML valid; macOS
cargo check --testsgreen (the new test is correctly excluded off Win/Linux). The Win/Linux CI on this PR exercises the new test.🤖 Generated with Claude Code