Skip to content

fix(ios): TestFlight marketing-version + CFBundleVersion (lost from #207) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oratis merged 2 commits into from
Jul 1, 2026
Merged

fix(ios): TestFlight marketing-version + CFBundleVersion (lost from #207) #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e34575
fix(ios): MARKETING_VERSION 0.1.0 → 1.0 (must be >= app's App Store v…
oratis Jul 1, 2026
f541147
fix(ios): stamp CFBundleVersion into the generated Info.plists (overr…
oratis Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packaging/ios-companion/project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ options:
settings:
base:
SWIFT_VERSION: "5.0"
MARKETING_VERSION: "0.1.0"
# Must be >= the app's App Store version (currently 1.0, PREPARE_FOR_SUBMISSION).
# A lower CFBundleShortVersionString (this was "0.1.0") is silently REJECTED by
# App Store Connect at ingestion — upload "succeeds" but no build ever appears.
MARKETING_VERSION: "1.0"
CURRENT_PROJECT_VERSION: "1"
TARGETED_DEVICE_FAMILY: "1,2"
# Automatic signing for device archives (testflight.sh): Xcode picks the
Expand Down
10 changes: 10 additions & 0 deletions packaging/ios-companion/testflight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,16 @@ if [ -f Sources/LisaPocket.entitlements ]; then
plutil -replace aps-environment -string production Sources/LisaPocket.entitlements
fi

# xcodegen bakes a LITERAL CFBundleVersion ("1") into the generated Info.plists,
# so `xcodebuild ... CURRENT_PROJECT_VERSION=$BUILD_NUMBER` never reaches the
# binary — every archive shipped build "1" and App Store Connect rejected the
# duplicates ("Redundant Binary Upload … build number 1/8"). Patch the plists
# directly. The app extension MUST carry the same version or embedded-binary
# validation fails.
echo "==> set CFBundleVersion=$BUILD_NUMBER (app + widget)"
plutil -replace CFBundleVersion -string "$BUILD_NUMBER" Sources/Info.plist
[ -f Widgets/Info.plist ] && plutil -replace CFBundleVersion -string "$BUILD_NUMBER" Widgets/Info.plist

AUTH=(-allowProvisioningUpdates
-authenticationKeyPath "$ASC_KEY_PATH"
-authenticationKeyID "$ASC_KEY_ID"
Expand Down