fix(ios): gate Sign in with Apple off for v1 (avoid App Store 5.1.1(v))#205
Merged
Conversation
Offering Sign in with Apple = account creation, which requires in-app account deletion (Guideline 5.1.1(v)) — and the cloud is still single-tenant M0 (SIWA isn't per-user yet), so it's not worth the review risk for the first submission. - Gate the SIWA button + handler in SettingsView and OnboardingFlow behind `#if LISA_ENABLE_SIWA` (undefined ⇒ compiled out). The "paste your cloud URL (with ?token=)" path stays as the cloud connect flow the reviewer uses. - Drop the `com.apple.developer.applesignin` entitlement from project.yml so the binary declares no SIWA capability. Re-enable (button + handler + entitlement) by adding LISA_ENABLE_SIWA to SWIFT_ACTIVE_COMPILATION_CONDITIONS once C3 (per-uid) + account deletion ship. Verified: build.sh BUILD SUCCEEDED (SIWA excluded); generated entitlements have no applesignin key. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIWA = account creation ⇒ Apple requires in-app account deletion (Guideline 5.1.1(v)). The cloud is still single-tenant M0 (SIWA isn't per-user yet), so it's not worth the review risk for the first submission.
#if LISA_ENABLE_SIWA(undefined ⇒ compiled out). The paste-cloud-URL (?token=) path — what the reviewer uses — stays.com.apple.developer.applesigninentitlement fromproject.yml.Re-enable via
LISA_ENABLE_SIWAinSWIFT_ACTIVE_COMPILATION_CONDITIONSonce C3 (per-uid) + account deletion ship.Verified:
build.shBUILD SUCCEEDED (SIWA excluded); generated entitlements have noapplesignin.🤖 Generated with Claude Code