Skip to content

Harden XML parsers against XXE attacks #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebTardif wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Harden XML parsers against XXE attacks #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e03287
Harden XML parsers against XXE attacks
SebTardif May 14, 2026
7af1905
Trigger OCA check
SebTardif May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion prj/coherence-core/src/main/java/com/oracle/coherence/common/schema/XmlSchemaSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020 Oracle and/or its affiliates.
* Copyright (c) 2020, 2025, Oracle and/or its affiliates.
*
* Licensed under the Universal Permissive License v 1.0 as shown at
* http://oss.oracle.com/licenses/upl.
Expand Down Expand Up @@ -104,6 +104,11 @@ public void populateSchema(Schema schema)
DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
dbf.setNamespaceAware(true);

// prevent XXE (XML External Entity) attacks
dbf.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
dbf.setFeature("http://xml.org/sax/features/external-general-entities", false);
dbf.setFeature("http://xml.org/sax/features/external-parameter-entities", false);

DocumentBuilder db = dbf.newDocumentBuilder();
Document doc = db.parse(m_inputXml);
Element root = doc.getDocumentElement();
Expand Down
14 changes: 14 additions & 0 deletions prj/coherence-core/src/main/java/com/tangosol/run/xml/SaxParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,20 @@ protected static Parser getParser()
ClassHelper.invoke(factory,
"setValidating", new Object[] {Boolean.FALSE});

// prevent XXE (XML External Entity) attacks
// factory.setFeature("http://xml.org/sax/features/external-general-entities", false);
ClassHelper.invoke(factory,
"setFeature", new Object[] {
"http://xml.org/sax/features/external-general-entities", Boolean.FALSE});
// factory.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
ClassHelper.invoke(factory,
"setFeature", new Object[] {
"http://xml.org/sax/features/external-parameter-entities", Boolean.FALSE});
// factory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
ClassHelper.invoke(factory,
"setFeature", new Object[] {
"http://apache.org/xml/features/nonvalidating/load-external-dtd", Boolean.FALSE});

// parser = factory.newSAXParser().getParser();
Object SAXParser = ClassHelper.invoke(factory,
"newSAXParser", ClassHelper.VOID);
Expand Down