[ODSC-72395] Changes to support multiple container versions in AQUA#1208
[ODSC-72395] Changes to support multiple container versions in AQUA#1208kumar-shivam-ranjan wants to merge 8 commits intomainfrom
Conversation
kumar-shivam-ranjan
requested review from
VipulMascarenhas,
ahosler,
darenr,
mayoor,
mrDzurb and
qiuosier
as code owners
oracle-contributor-agreement
Bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
| """ | ||
|
|
||
| inference: Dict[str, AquaContainerConfigItem] = Field( | ||
| inference: Dict[str, List[AquaContainerConfigItem]] = Field( |
There was a problem hiding this comment.
this change will break in a few places where AquaContainerConfig is used, likely in deployment.py. Can you check if that class needs changes?
There was a problem hiding this comment.
Sure , will check , thanks
|
To move forward with this PR, I think we need to clarify what happens with deprecated containers. If we update the config and mark a container as inactive, what’s the expected behavior, will the container be removed from the container registry, or will it remain available but hidden? |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
4 participants
Description
This PR is intended to update the container config reader to recognize and expose a list of all active container versions per container family. Previously, only the latest was considered. Update the deployment handler to include all available active container versions for a selected family, so the UI can populate a dropdown with multiple options.
Related PR
https://bitbucket.oci.oraclecorp.com/projects/ODSC/repos/odsc-pegasus-control-plane/pull-requests/4565/overview
Unit Tests
TODO
Test Results
CP API
ADS AQUA API