refactor: adopt dead helpers identified by Titan grind

[carlos-alm]

Summary

Adopt dead helpers identified by the Titan GRIND phase — wiring previously-extracted-but-unused helpers into real call sites, and promoting/deduping a few forge-phase helpers that turned out to have further adoption opportunities:

• Adopt fget/iget from typed-array-helpers.ts in cpm.ts/modularity.ts (leiden).
• Wire db.busyTimeoutMs and community.capacityGrowthFactor config constants through their real call sites (db/connection, builder pipeline, watcher, communities, leiden).
• Adopt resolveMethodDefinitionName across 3 duplicate call sites in extractors/javascript.ts.
• Dedupe forge phase-11 call-resolution helpers (unwrapTypeEntry, resolveSameClassQualifiedMethod) across build-edges.ts/incremental.ts.
• Extract markExportedSymbols, dedupe a batch UPDATE in builder helpers.
• Promote timeMedian/median/round1 into a shared scripts/lib/bench-timing.ts, deduping the same logic across 3 benchmark scripts.

Titan Audit Context

• Phase: adoption
• Domain: cross-cutting (leiden, config/db/builder, extractors, resolver, scripts)
• Commits: 6
• Depends on: PR Bump tree-sitter-python from 0.23.6 to 0.25.0 #7 (warning improvements) — this PR's commits reference symbols extracted across the full forge stack (PRs Bump actions/setup-node from 4 to 6 #1-Bump tree-sitter-python from 0.23.6 to 0.25.0 #7), so it must merge after all of them

Changes

• src/graph/algorithms/leiden/{cpm,modularity}.ts
• src/db/connection.ts, src/domain/graph/builder/{pipeline,watcher}..., src/domain/graph/builder/stages/{native-db-lifecycle,native-orchestrator}.ts, src/features/communities.ts, src/graph/algorithms/leiden/{optimiser,partition}.ts, src/graph/algorithms/louvain.ts, src/infrastructure/config.ts, src/types.ts
• src/extractors/javascript.ts
• src/domain/graph/builder/{call-resolver,incremental}.ts, src/domain/graph/builder/stages/build-edges.ts, src/domain/graph/resolver/strategy.ts
• src/domain/graph/builder/{helpers,stages/insert-nodes,stages/native-orchestrator}.ts
• scripts/{benchmark,incremental-benchmark,query-benchmark,token-benchmark}.ts, new scripts/lib/bench-timing.ts

Metrics Impact

The Titan GRIND phase triaged 24 candidate dead-symbol targets: 6 were genuinely adoptable (this PR), 3 were promoted/deduped further (also this PR), and the remaining 15 were confirmed false positives caused by known codegraph role-classifier bugs (documented in generated/titan/ report and filed as GitHub issues).

Test plan

• CI passes (lint + build + tests)
• codegraph check --cycles --boundaries passes
• No new functions above complexity thresholds

[greptile-apps]

Greptile Summary

This PR wires previously-extracted-but-unused helpers into real call sites across 25 files, reducing duplication without altering observable behaviour. All changes are mechanical adoptions: promoting shared helpers (fget/iget, resolveMethodDefinitionName, resolveSameClassQualifiedMethod, unwrapTypeEntry, markExportedSymbols, timeMedian/median/round1) and threading two previously-hardcoded config constants (busyTimeoutMs, capacityGrowthFactor) through their full call paths.

• scripts/lib/bench-timing.ts (new): Canonical median/round1/timeMedian replaces four independent duplicates across the benchmark scripts; timeMedian now takes an explicit runs parameter (the old local copy in token-benchmark.ts had a default of PERF_RUNS), and all call sites pass the constant explicitly.
• src/db/connection.ts: resolveDbEngine becomes resolveDbSettings, adding busyTimeoutMs to the returned struct so the same loadConfig() call covers both fields; all openDb invocations in pipeline, watcher, and native-orchestrator now pass the user-configured value.
• src/graph/algorithms/leiden/partition.ts: Exports DEFAULT_CAPACITY_GROWTH_FACTOR (previously a silent triplicate in optimiser.ts, partition.ts, and config.ts), reducing drift surface; capacityGrowthFactor is now a typed field on PartitionState and flows from communitiesData() all the way to ensureCommCapacity().

Confidence Score: 5/5

Safe to merge — all changes are mechanical deduplication of helpers that were already proven correct at their original sites.

Every adoption is a like-for-like substitution: the extracted functions reproduce the exact same logic as the inlined code they replace. The busyTimeoutMs threading correctly defaults to DEFAULTS.db.busyTimeoutMs at both the parameter level and the resolveDbSettings fallback. The resolveMethodDefinitionName consolidation preserves the per-site early-exit variant (return vs continue). The markExportedSymbols refactor upgrades from a per-call Map to a module-level WeakMap cache, which is strictly better. No logic changes were made — only consolidation of duplicates.

No files require special attention beyond the minor style inconsistency in scripts/lib/bench-timing.ts (missing explicit performance import).

Important Files Changed

Filename	Overview
scripts/lib/bench-timing.ts	New shared timing lib extracting median/round1/timeMedian; uses global performance without an explicit import (all other scripts import from node:perf_hooks)
src/db/connection.ts	Refactors resolveDbEngine → resolveDbSettings to return both engine and busyTimeoutMs in a single loadConfig call; openDb/openReadonlyOrFail now accept a busyTimeoutMs parameter defaulting to DEFAULTS.db.busyTimeoutMs
src/domain/graph/builder/call-resolver.ts	Promotes the resolveSameClassQualifiedMethod helper (previously duplicated in build-edges.ts and incremental.ts) to a shared export; logic is unchanged
src/domain/graph/builder/helpers.ts	Adds markExportedSymbols backed by a module-level WeakMap cache (upgrade from per-call Map), deduplicating the chunked UPDATE loop from insert-nodes.ts and native-orchestrator.ts
src/extractors/javascript.ts	Three independent computed-property-name unwrapping blocks replaced by calls to the shared resolveMethodDefinitionName; behavior preserved for all three call sites (return/return/continue early-exit variants)
src/graph/algorithms/leiden/partition.ts	Exports DEFAULT_CAPACITY_GROWTH_FACTOR (reducing from 3 copies to 2), adds capacityGrowthFactor to PartitionState so ensureCommCapacity uses the configurable value instead of the hardcoded 1.5 literal
src/graph/algorithms/leiden/optimiser.ts	Removes its own DEFAULT_CAPACITY_GROWTH_FACTOR copy, now importing from partition.ts; threads capacityGrowthFactor through NormalizedOptions and into both makePartition call sites
src/domain/graph/builder/stages/build-edges.ts	Adopts resolveSameClassQualifiedMethod from call-resolver and unwrapTypeEntry from resolver/strategy, removing two inline duplicates; logic unchanged
src/domain/graph/builder/stages/native-orchestrator.ts	All openDb calls now pass ctx.config.db.busyTimeoutMs; duplicate export-marking loop replaced with markExportedSymbols
src/graph/algorithms/louvain.ts	Threads capacityGrowthFactor through LouvainOptions; native Rust path now logs a warning when it is set (same pattern as the other Leiden-only options)
src/features/communities.ts	Adds capacityGrowthFactor to CommunitiesDataOpts and threads opts.capacityGrowthFactor ?? config.community?.capacityGrowthFactor through to louvainCommunities

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant CD as communitiesData()
    participant LC as louvainCommunities()
    participant LJ as louvainJS() / detectClusters()
    participant MP as makePartition()
    participant EC as ensureCommCapacity()

    CD->>LC: capacityGrowthFactor (opts ?? config)
    LC->>LJ: "capacityGrowthFactor (if != null)"
    LJ->>LJ: normalizeOptions() → capacityGrowthFactor (or DEFAULT_CAPACITY_GROWTH_FACTOR)
    LJ->>MP: "makePartition(graph, { capacityGrowthFactor })"
    MP->>EC: s.capacityGrowthFactor stored in PartitionState
    EC->>EC: "Math.ceil(length * s.capacityGrowthFactor) — previously hardcoded 1.5"

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant CD as communitiesData()
    participant LC as louvainCommunities()
    participant LJ as louvainJS() / detectClusters()
    participant MP as makePartition()
    participant EC as ensureCommCapacity()

    CD->>LC: capacityGrowthFactor (opts ?? config)
    LC->>LJ: "capacityGrowthFactor (if != null)"
    LJ->>LJ: normalizeOptions() → capacityGrowthFactor (or DEFAULT_CAPACITY_GROWTH_FACTOR)
    LJ->>MP: "makePartition(graph, { capacityGrowthFactor })"
    MP->>EC: s.capacityGrowthFactor stored in PartitionState
    EC->>EC: "Math.ceil(length * s.capacityGrowthFactor) — previously hardcoded 1.5"

Loading

_{Reviews (3): Last reviewed commit: "fix(leiden): dedupe DEFAULT_CAPACITY_GRO..." | Re-trigger Greptile}

[greptile-apps]

Three copies of the same 1.5 default now exist independently: DEFAULT_CAPACITY_GROWTH_FACTOR here, DEFAULT_CAPACITY_GROWTH_FACTOR in partition.ts, and DEFAULTS.community.capacityGrowthFactor in config.ts. The value in optimiser.ts normalises the option before it reaches makePartition, but partition.ts also keeps its own copy as a last-resort fallback for callers that skip the optimiser layer. If the tuning value ever changes, all three sites must be updated atomically — any miss silently produces mismatched growth behaviour depending on which code path ran. Importing the constant from one canonical location would close that gap.

Suggested change

	const DEFAULT_CAPACITY_GROWTH_FACTOR: number = 1.5;
	import { DEFAULT_CAPACITY_GROWTH_FACTOR } from './partition.js';

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[carlos-alm]

Fixed — exported DEFAULT_CAPACITY_GROWTH_FACTOR from partition.ts and imported it in optimiser.ts instead of keeping an independent literal. The third copy (DEFAULTS.community.capacityGrowthFactor in config.ts) is intentionally kept separate — it follows the same established pattern as DEFAULT_MAX_LEVELS/DEFAULT_MAX_LOCAL_PASSES in this file (module-level fallback mirrored from the user-facing config default, documented via comment), so no further action needed there.

[github-actions]

Codegraph Impact Analysis

47 functions changed → 231 callers affected across 114 files

• median in scripts/lib/bench-timing.ts:24 (13 transitive callers)
• round1 in scripts/lib/bench-timing.ts:34 (10 transitive callers)
• timeMedian in scripts/lib/bench-timing.ts:44 (5 transitive callers)
• runPerfBenchmarks in scripts/token-benchmark.ts:262 (2 transitive callers)
• openDb in src/db/connection.ts:161 (21 transitive callers)
• openReadonlyOrFail in src/db/connection.ts:333 (126 transitive callers)
• ResolvedDbSettings.engine in src/db/connection.ts:360 (0 transitive callers)
• ResolvedDbSettings.busyTimeoutMs in src/db/connection.ts:361 (0 transitive callers)
• resolveDbSettings in src/db/connection.ts:374 (24 transitive callers)
• openRepo in src/db/connection.ts:427 (28 transitive callers)
• openReadonlyWithNative in src/db/connection.ts:482 (8 transitive callers)
• resolveSameClassQualifiedMethod in src/domain/graph/builder/call-resolver.ts:48 (8 transitive callers)
• getExportStmt in src/domain/graph/builder/helpers.ts:453 (15 transitive callers)
• markExportedSymbols in src/domain/graph/builder/helpers.ts:470 (7 transitive callers)
• applyThisReceiverFallbacks in src/domain/graph/builder/incremental.ts:600 (5 transitive callers)
• setupPipeline in src/domain/graph/builder/pipeline.ts:173 (4 transitive callers)
• runPipelineStages in src/domain/graph/builder/pipeline.ts:277 (4 transitive callers)
• resolveReflectionKeyExprFallback in src/domain/graph/builder/stages/build-edges.ts:1137 (3 transitive callers)
• resolveDefinePropertyAccessorFallback in src/domain/graph/builder/stages/build-edges.ts:1182 (3 transitive callers)
• insertDefinitionsAndExports in src/domain/graph/builder/stages/insert-nodes.ts:258 (3 transitive callers)

[carlos-alm]

Addressed Greptile's review feedback: exported DEFAULT_CAPACITY_GROWTH_FACTOR from partition.ts and imported it in optimiser.ts (commit da0c267) instead of keeping an independently-drifting literal. See inline reply for details on why the third copy in config.ts is intentionally kept separate.

[carlos-alm]

@greptileai