Skip to content

fix(slurpitsync): improve node ID handling for matching nodes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minitriga merged 3 commits into from
Feb 17, 2026
Merged

fix(slurpitsync): improve node ID handling for matching nodes #112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdf7794
fix(slurpitsync): improve node ID handling for matching nodes
minitriga Feb 17, 2026
8caf063
Merge branch 'main' into atg-20260217-slurpit
minitriga Feb 17, 2026
1885cd4
Merge branch 'main' into atg-20260217-slurpit
minitriga Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions infrahub_sync/adapters/slurpitsync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,12 @@ def slurpit_obj_to_diffsync(
if not field_is_list:
if node := obj.get(field.mapping):
matching_nodes = []
node_id = build_mapping(adapter=self, reference=field.reference, obj=obj, field=field)
matching_nodes = [item for item in nodes if str(item) == node_id]
# If node is a simple string/value, use it directly; otherwise build from nested object
if isinstance(node, (str, int)):
node_id = str(node)
else:
node_id = build_mapping(adapter=self, reference=field.reference, obj=obj, field=field)
matching_nodes = [item for item in nodes if item.get_unique_id() == node_id]
if len(matching_nodes) == 0:
self.skipped.append(node)
return None
Expand All @@ -266,7 +270,7 @@ def slurpit_obj_to_diffsync(
data[field.name] = []
if node := obj.get(field.mapping):
node_id = build_mapping(adapter=self, reference=field.reference, obj=obj, field=field)
matching_nodes = [item for item in nodes if str(item) == node_id]
matching_nodes = [item for item in nodes if item.get_unique_id() == node_id]
if len(matching_nodes) == 0:
self.skipped.append(node)
continue
Expand Down