IFC-2303: update SDK protocols for CoreKeyValue schema#867
IFC-2303: update SDK protocols for CoreKeyValue schema#867polmichel wants to merge 3 commits intoinfrahub-developfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds value-bearing key-value node types to 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
Deploying infrahub-sdk-python with
|
| Latest commit: |
fc3dce0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87cab0f7.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pmi-20260313-schema-updates.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #867 +/- ##
====================================================
+ Coverage 80.64% 80.70% +0.05%
====================================================
Files 118 118
Lines 10246 10266 +20
Branches 1534 1534
====================================================
+ Hits 8263 8285 +22
+ Misses 1455 1454 -1
+ Partials 528 527 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Once the Infrahub side of this has been merged this PR might need some updates but should be ready to go. The only comment would be that we need to hold off with the merge until after Infrahub 1.8 and SDK 1.19.0 has been released. Since we don't have a specific infrahub-develop branch for each release within the SDK. |
…amed CoreEnvKeyValue
Why
Synchronization step with opsmill/infrahub#8590 which introduces
CoreKeyValueschema definitions for webhook custom headers.This PR updates the SDK-side generated protocols to reflect the new schema entities added in the infrahub backend.
What changed
infrahub_sdk/protocols.py: Added generated protocol classes forCoreKeyValue,CoreStaticKeyValue, andCoreEnvironmentVariableKeyValuegenerics/nodes introduced in IFC-2303: CoreKeyValue schema definitions for webhook custom headers infrahub#8590No behavioral changes — this is purely additive generated protocol updates to stay in sync with the backend schema.
How to review
infrahub_sdk/protocols.pydiff — the new protocol stubs matching the backend schema additionsHow to test
Impact & rollout
Summary by CodeRabbit