This repository was archived by the owner on Jul 8, 2021. It is now read-only.
Update Measure variable names to meet PEP8#3
Open
rstarmer wants to merge 1 commit intoopsani:masterfrom
Open
Conversation
Metrics names were re-worked to be PEP8 compliant as they are levarged when defining performance management interactions and so need to be valide Python variables. The #TODO was also removed
Contributor
Author
|
@pnickolov @ekalosak Can you please review and merge if acceptable. |
|
lgtm, converted spaces to underscores, a win in my book. |
|
Not sure what you mean by |
Contributor
Author
|
@pavel-georgiev That is what I meant, and I wasn't aware of the array name being returned. I still think this is easier, especially for someone wanting to work with a single parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics names were re-worked to be PEP8 compliant as they
are leveraged when defining performance management interactions
and so need to be valid Python variables. The #TODO was also
removed