Conversation
Signed-off-by: xesrevinu <github-action@actions-template-sync.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ignorePaths: [ | ||
| ...getDefaultIgnorePaths(), | ||
| ...allowExtensions([ | ||
| '*.swift', | ||
| '*.h', |
There was a problem hiding this comment.
In scripts/thing/utils/fingerprint.ts, getOtaFingerprintOptions builds ignorePaths by spreading getDefaultIgnorePaths() (which returns ['**/*', ...]) and then only un-ignoring native extensions (*.swift, *.kt, etc.) while also excluding android/** and ios/** (lines 76–110). This effectively excludes all JS/TS/assets from the OTA hash, so JS-only changes will produce identical fingerprints and deploy-check will report jsChanged false, preventing hot updates or misclassifying change scope. Remove the blanket **/* ignore or explicitly un-ignore JS/asset patterns so OTA fingerprints track JS changes.
Useful? React with 👍 / 👎.
| cwd: nativeCwdOption, | ||
| base: nativeBaseOption, | ||
| head: nativeBaseOption, | ||
| platform: nativeRunPlatformOption, |
There was a problem hiding this comment.
In scripts/thing/react-native/command.ts, the analyze command binds head to nativeBaseOption, so there is no --head flag and any --base value is reused for both base and head. As a result resolveHead returns the base commit and collectChangedFiles(base, head) sees no differences, which makes react-native analyze unable to analyze a real range when users specify --base. This should use nativeHeadOption for the head field.
Useful? React with 👍 / 👎.
1 participant
Merge https://github.com/opraying/template 204a226