Conversation
Signed-off-by: xesrevinu <github-action@actions-template-sync.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| static FromTags = (layerRecord: Record<PaymentProviderTag, Layer.Layer<PaymentImpl>>) => | ||
| Payment.Default.pipe(Layer.provide(PaymentTags.FromRecords(layerRecord))) | ||
|
|
||
| static client = Payment.pipe(Effect.flatMap((_) => _.use('any' as PaymentProviderTag))) |
There was a problem hiding this comment.
Payment client hardcodes nonexistent provider
Payment.client now calls _.use('any' as PaymentProviderTag), but PaymentProviderTag only permits paddle or stripe. When Payment.client is used (e.g., the purchase webhook sync code resolves Payment.client), the provider lookup tags.providers['any'] is undefined and Effect.provide fails before any client is returned, so the helper cannot be used at runtime.
Useful? React with 👍 / 👎.
Merge https://github.com/opraying/xstack-base c01bb03