Open
Conversation
SamD2021
force-pushed
the
feat/upstream-k8s-portability
branch
3 times, most recently
from
8990461 to
b8ac221
Compare
Contributor
|
I would copy the entire DPU Operator from OpenShift. Not just having the manifests and such. |
SamD2021
force-pushed
the
feat/upstream-k8s-portability
branch
6 times, most recently
from
66e4349 to
3eafae3
Compare
wizhaoredhat
reviewed
Apr 2, 2026
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
wizhaoredhat
reviewed
Apr 7, 2026
| } | ||
| "range_end": "10.56.217.150", | ||
| "kubernetes": { | ||
| "kubeconfig": "/etc/cni/net.d/whereabouts.d/whereabouts.kubeconfig" |
Contributor
There was a problem hiding this comment.
This looks strange... Could you explain why this is needed?
wizhaoredhat
reviewed
Apr 7, 2026
| -output-file bin/local-images.yaml | ||
| - cp config/dev/kustomization.yaml bin | ||
|
|
||
| deploy-webhook-compat: |
Contributor
There was a problem hiding this comment.
Name of this task doesn't really tell the read what it does. Please add commentary
wizhaoredhat
reviewed
Apr 7, 2026
| - bin/kustomize build bin | KUBECONFIG="{{.KUBECONFIG_HOST}}" oc apply -f - | ||
| - KUBECONFIG="{{.KUBECONFIG_HOST}}" oc -n openshift-dpu-operator wait --for=condition=Available deployment/dpu-operator-controller-manager --timeout=300s | ||
| - KUBECONFIG="{{.KUBECONFIG_HOST}}" oc -n openshift-dpu-operator wait --for=condition=ready pod --all --timeout=300s | ||
| - bin/kustomize build bin | KUBECONFIG="{{.KUBECONFIG_HOST}}" kubectl apply -f - |
Contributor
There was a problem hiding this comment.
kubectl and oc should be allowed. Meaning we should have a it defined as $OCI_BIN and we can detect which is installed.
wizhaoredhat
reviewed
Apr 7, 2026
| return p.wrap("/run/cni"), nil | ||
| // OpenShift typically uses /var/lib/cni regardless of filesystem mode since nodes are always coreos based | ||
| case clusterFlavour == OpenShiftFlavour: | ||
| case clusterFlavour == OpenShiftFlavour || (clusterFlavour == VanillaFlavour && filesystemMode == ImageMode): |
Contributor
There was a problem hiding this comment.
VanillaFlavour is confusing...
wizhaoredhat
reviewed
Apr 7, 2026
| @@ -0,0 +1,13 @@ | |||
| package utils | |||
Contributor
There was a problem hiding this comment.
why do we need a new file for this?
wizhaoredhat
reviewed
Apr 7, 2026
| - ../webhook | ||
| # [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'. 'WEBHOOK' components are required. | ||
| #- ../certmanager | ||
| - ../certmanager |
Contributor
There was a problem hiding this comment.
How does upstream sriov network operator and downstream sriov network operator handle this?
… switching - add non-.rhel Dockerfiles for manager/daemon/VSP/NRI images - keep .rhel Dockerfiles unchanged and selectable via DOCKERFILE_SUFFIX - add build-image-all-rhel and clean-image-all-rhel wrappers - make REGISTRY overridable in taskfile - fix pip RPM-setuptools conflict in openshift/install-dpu.sh Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
- add PUSH_TLS_VERIFY (default true) to push-image-helper - allow --tls-verify=false for insecure local registries - unset GOOS/GOARCH for go-install tool tasks (kustomize/ginkgo/controller-gen/envtest) Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
- replace oc with kubectl in taskfile deploy and undeploy paths - update README example command accordingly Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
…ader lock Adds ipam.kubernetes.kubeconfig=/etc/cni/net.d/whereabouts.d/whereabouts.kubeconfig to the host NAD template so dpu-cni uses the intended Whereabouts identity across vanilla/OpenShift-style environments, preventing time limit exceeded while waiting to become leader during pod network setup. Signed-off-by: Sam DaSilva <sam.ramos.dasilva@gmail.com>
SamD2021
force-pushed
the
feat/upstream-k8s-portability
branch
from
3eafae3 to
099b1d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.