WIP: PoC: use the rukpak PoC OCI artifact source#266
Closed
joelanford wants to merge 2 commits intooperator-framework:mainfrom
Closed
WIP: PoC: use the rukpak PoC OCI artifact source#266joelanford wants to merge 2 commits intooperator-framework:mainfrom
joelanford wants to merge 2 commits intooperator-framework:mainfrom
Conversation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
dbf285f to
9d22216
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
9d22216 to
2a38b10
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
perdasilva
reviewed
Jul 17, 2023
| @@ -1,9 +1,9 @@ | |||
| apiVersion: catalogd.operatorframework.io/v1alpha1 | |||
Contributor
There was a problem hiding this comment.
would it be better to add a new sample rather than edit the existing one? Or are we subbing out image src in favor of oci?
perdasilva
reviewed
Jul 17, 2023
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| sourceType := rukpakv1alpha1.SourceTypeImage |
Contributor
There was a problem hiding this comment.
should this logic move to rukpak?
perdasilva
reviewed
Jul 17, 2023
| github.com/operator-framework/catalogd v0.3.0 | ||
| github.com/operator-framework/deppy v0.0.0-20230602120738-cbf2c66b141b | ||
| github.com/operator-framework/operator-registry v1.26.3 | ||
| github.com/operator-framework/operator-registry v1.28.0 |
Contributor
There was a problem hiding this comment.
do we want a separate PR for this?
Member
Author
|
Closing since this served its purpose for demos and there are no plans to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup
Clone the 4 repos and checkout the correct commits:
Setup binaries and cluster
Demo Script
Example commands + Build and push bundles
Create an OCI Artifact-based catalog and examine catalog APIs
Create an Operator for prometheus and argo-cd and example operator-controller APIs
Example rukpak APIs
Check if expected CRDs are installed
Remove grafana-operator from the catalog, rebuild, and push
Force another reconcile of the catalog, and verify the digest changed
Verify that the grafana-operator package and bundlemetadata disappeared
Note 1
The OCI artifact spec is still very much in flux. In fact the
"application/vnd.oci.artifact.manifest.v1+json"(which this demo uses) was removed from the spec just recently, and replaced with other modifications to the pre-existing OCI image manifest type.See opencontainers/image-spec#999 (comment)
Note 2
There is a referrers API as part of the in-progress OCI spec. This enables new objects to refer to existing objects without changing the digest of the existing objects. This is perfect for use cases like deprecation and retroactive assertions. Unfortunately, I can't demo this because docker hub doesn't support the referrers API (yet?)
Reviewer Checklist