improve: log error in NodeExecutor #3102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm
reviewed
Dec 22, 2025
| workflowExecutor.handleExceptionInExecutor(dependentResourceNode, e); | ||
| } catch (Error e) { | ||
| // without this user would see no sign about the error | ||
| log.error("java.lang.Error during execution", e); |
Collaborator
There was a problem hiding this comment.
Should we also add it to the incremental recording of error messages that the workflow keeps?
Collaborator
Author
There was a problem hiding this comment.
I think we should not, this is just for a corner case, where we receive Errors. Those should not be caught in general in Java, and indicate a fundamental issue. Think of receving here an OutOfMemoryError. But also from the original reported issue the NoSuchFieldError indicates an issue with the bytecode. So we simply should not handle it.
metacosm
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com