Skip to content

Fix PR 204 review issues#207

Merged
mirzaees merged 3 commits intoopera-adt:mainfrom
mirzaees:fix_pr_204_issues
Feb 18, 2026
Merged

Fix PR 204 review issues#207
mirzaees merged 3 commits intoopera-adt:mainfrom
mirzaees:fix_pr_204_issues

Conversation

@mirzaees
Copy link
Copy Markdown
Contributor

test imports, monkeypatch paths, assertion and timezone handling

  • Replace assert statements with ValueError in _download.py (stripped by python -O)
  • Fix timezone handling in _search.py to preserve tz-aware datetimes
  • Fix test monkeypatch paths: opera_utils.nisar._remote -> opera_utils._remote
  • Fix test mock paths: opera_utils.nisar._search.requests -> opera_utils._cmr.requests
  • Fix test import: _get_download_url moved to opera_utils._cmr.get_download_url
  • Fix mock lambda signatures to accept keyword args (host, asf_endpoint)
  • Fix docstring resolution mismatch (100m -> 60m) in example
  • Add doctest: +SKIP to run_download example requiring credentials

…, and timezone handling

- Replace assert statements with ValueError in _download.py (stripped by python -O)
- Fix timezone handling in _search.py to preserve tz-aware datetimes
- Fix test monkeypatch paths: opera_utils.nisar._remote -> opera_utils._remote
- Fix test mock paths: opera_utils.nisar._search.requests -> opera_utils._cmr.requests
- Fix test import: _get_download_url moved to opera_utils._cmr.get_download_url
- Fix mock lambda signatures to accept keyword args (host, asf_endpoint)
- Fix docstring resolution mismatch (100m -> 60m) in example
- Add doctest: +SKIP to run_download example requiring credentials
@mirzaees mirzaees merged commit b95349a into opera-adt:main Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant