resolves #144: Zim UI inside pip package#145
Merged
benoit74 merged 1 commit intoopenzim:mainfrom Apr 27, 2026
Merged
Conversation
benoit74
reviewed
Mar 27, 2026
Collaborator
benoit74
left a comment
benoit74
left a comment
There was a problem hiding this comment.
Thank you. Few questions
aaryansinhaa
force-pushed
the
issue-144-add-zimui-to-pip
branch
from
7edf166 to
8d9bbbc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 11 11
Lines 477 477
Branches 92 92
=======================================
Hits 159 159
Misses 313 313
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaryansinhaa
force-pushed
the
issue-144-add-zimui-to-pip
branch
from
8d9bbbc to
dc70514
Compare
Collaborator
|
@aaryansinhaa what is this last commit about? |
Contributor
Author
|
It was an accidental commit, i was trying to revert my changes due to formating, fixing it, sorry for the inconvenience |
aaryansinhaa
force-pushed
the
issue-144-add-zimui-to-pip
branch
from
0ab3ea4 to
67ec1be
Compare
aaryansinhaa
force-pushed
the
issue-144-add-zimui-to-pip
branch
from
67ec1be to
0dc25e0
Compare
Contributor
Author
|
@benoit74 can you please review this PR. thanks! |
benoit74
approved these changes
Apr 27, 2026
Collaborator
|
Got lost in my notification stack, sorry. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
zimui/src/components/challenge/ChallengeMobile.vue,zimui/src/components/challenge/ChallengeMobile.vue,zimui/src/components/challenge/CodeEditor.vueandzimui/src/style.csswas formatted whenyarn format.