Skip to content

streamline shuttle move/copy operations#274

Open
elfkuzco wants to merge 1 commit intomainfrom
simplify-move-files
Open

streamline shuttle move/copy operations#274
elfkuzco wants to merge 1 commit intomainfrom
simplify-move-files

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

@elfkuzco elfkuzco commented May 7, 2026

Rationale

This PR simplifies the file movement operation of the shuttle. It does this in the following way:

  • keep one current location as the source of truth since all the book data (file) is the same across all current locations
  • create the target locations using this first current location while simultaneously deleting any current location that isn't the original we are holding a reference to. Caveat is that book events are now showing as copies and not really as moves from one current location to another
  • delete the original location and any other current locations that are left (especially if current location is greater than target locations)

This fixes #233

@elfkuzco elfkuzco self-assigned this May 7, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 7, 2026 10:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (53ad7cf) to head (43b7d04).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   81.39%   81.30%   -0.09%     
==========================================
  Files          55       55              
  Lines        2354     2343      -11     
  Branches      233      233              
==========================================
- Hits         1916     1905      -11     
  Misses        378      378              
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since we cannot really move file, rationalize codebase

1 participant