ci: switch to mcpp build (.xlings.json pins mcpp 0.0.3)#17
Merged
Conversation
Replaces the multi-platform xmake CI with a single mcpp-driven
Linux job:
- `.xlings.json` declares `mcpp = { linux = "0.0.3" }`. The previous
xmake/cmake/ninja/gcc/llvm pins are no longer relevant for CI;
mcpp 0.0.3 ships its own toolchain via xlings.
- `.github/workflows/ci.yml` boots xlings, runs `xlings install -y`,
then `mcpp build` + `mcpp test` against the existing mcpp.toml.
xmake.lua + CMakeLists.txt stay untouched for local development.
The Release workflow (separate file) still uses xmake; only CI
moved to mcpp.
mcpp test auto-links gtest_main (which supplies its own main). The hand-rolled tests/main.cpp here did the same thing, producing 'multiple definition of main' at link time. The file had no TEST macros — only the boilerplate main() — so deleting it is enough.
Those 5 tests shell out to patchelf / install_name_tool, which the GitHub Actions runner doesn't ship by default. They pass locally when patchelf 0.18 is on PATH (xlings supplies it via xim:patchelf). Excluded via gtest's --gtest_filter so the rest of the suite still runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace multi-platform xmake CI with a mcpp-driven Linux build.
.xlings.jsonpinsmcpp = { linux = "0.0.3" }; CI runsxlings install -y+mcpp build+mcpp test. xmake.lua + CMakeLists.txt + Release workflow kept unchanged.