Optimize Xprof Dashboard latency/CPU usage: cut 38% for all view based on PreprocessSingleHostXSpace and additionally ~38% for summary view ConvertXSpaceToOpStats#2380
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
…sed on `PreprocessSingleHostXSpace` and additionally `~38%` for summary view `ConvertXSpaceToOpStats` For `451mb` single host profile data (maxtext) `PreprocessSingleHostXSpace` from `6.8sec` to `4.4sec` and `ConvertXSpaceToOpStats` from `42.4sec` to `26sec` END_PUBLIC ## Details 1. `PreprocessSingleHostXSpace` cache result of `ParseTfOpFullname` ~18%` latency red 1. `PreprocessSingleHostXSpace` `DeriveLinesFromStats` cache event metadata stats `17%` 1. `ConvertXSpaceToOpStats` `XEventsOpMetricsDbBuilder` avoid copy `15%` red 1. `ConvertXSpaceToOpStats` `SetPerCoreOpMetricsDb` avoid copy `%23` red PiperOrigin-RevId: 880757399
copybara-service
bot
force-pushed
the
test_880757399
branch
from
9f4a3af to
68d67d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize Xprof Dashboard latency/CPU usage: cut
38%for all view based onPreprocessSingleHostXSpaceand additionally~38%for summary viewConvertXSpaceToOpStatsFor
451mbsingle host profile data (maxtext)PreprocessSingleHostXSpacefrom6.8secto4.4secandConvertXSpaceToOpStatsfrom42.4secto26secEND_PUBLIC
Details
PreprocessSingleHostXSpacecache result ofParseTfOpFullname~18%` latency redPreprocessSingleHostXSpaceDeriveLinesFromStatscache event metadata stats17%ConvertXSpaceToOpStatsXEventsOpMetricsDbBuilderavoid copy15%redConvertXSpaceToOpStatsSetPerCoreOpMetricsDbavoid copy%23red