Enable Modulo 1 simplification in SymbolicExpr.#39421
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 19, 2026
Merged
Enable Modulo 1 simplification in SymbolicExpr.#39421copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_885562759
branch
2 times, most recently
from
b0affcb to
576c58e
Compare
This change adds a basic simplification rule for the modulo operator in SymbolicExpr, where `x % 1` and `x % -1` are simplified to 0. This allows a failing test in IndexingAnalysis to pass. I also added `x / 1` basic simplification (add and mul were already there). This is still a temporary solution. Ideally we should run canonicalizer at creation but this will break many tests so I am planning to do it after finalizing the migration. PiperOrigin-RevId: 886087149
copybara-service
Bot
force-pushed
the
test_885562759
branch
from
576c58e to
c3d9fb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Modulo 1 simplification in SymbolicExpr.
This change adds a basic simplification rule for the modulo operator in SymbolicExpr, where
x % 1andx % -1are simplified to 0. This allows a failing test in IndexingAnalysis to pass. I also addedx / 1basic simplification (add and mul were already there).This is still a temporary solution. Ideally we should run canonicalizer at creation but this will break many tests so I am planning to do it after finalizing the migration.