wifi-chipset-detect: new package#1158
Conversation
Ooh. That's interesting....
I guess there is a reason for everything.... |
|
@BKPepe @mwarning |
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://codeload.github.com/opennds/wifi-chipset-detect/tar.gz/v$(PKG_VERSION)? | ||
| PKG_HASH:=2e4d60861df598dbb13e0133a7ccaa4efa2534c158ae92852d693791e0f206b7 | ||
| PKG_BUILD_DIR:=$(BUILD_DIR)/wifi-chipset-detect-$(PKG_VERSION) |
There was a problem hiding this comment.
This is already default. It can be removed
There was a problem hiding this comment.
Sorry, I don't follow. Which line is default?
There was a problem hiding this comment.
@BKPepe
Ah! If you mean line 18 (PKG_SOURCE) then yes it is the default, BUT the next line (PKG_SOURCE_URL) is in the Github Codeload format for the release tag which has a leading letter "v".
As far as I can see, when PKG_SOURCE is not explicitly set, it falls back to deriving the filename from the last component of PKG_SOURCE_URL (after stripping the query ?).
In turn this would mean the unpacked directory and PKG_BUILD_DIR would be incorrect and the build would fail.
I tested this in the SDK and yes, it failed.
There was a problem hiding this comment.
| PKG_BUILD_DIR:=$(BUILD_DIR)/wifi-chipset-detect-$(PKG_VERSION) |
There was a problem hiding this comment.
OK, I see what you are saying, but when building with the SDK after deleting this line, I get:
ERROR: package/feeds/routing/wifi-chipset-detect failed to build.
If I put it back in, it builds fine.
Is this an SDK artefact, or something deeper?
If you are sure it is not needed here, then all well and good.
EDIT: CI is happy with it deleted, so I'm happy too 😆
| include $(INCLUDE_DIR)/package.mk | ||
|
|
||
| define Package/wifi-chipset-detect | ||
| SUBMENU:=Captive Portals |
There was a problem hiding this comment.
I am not quite sure, if this submenu is alright. Standalone tool to detect wifi chipset. Not exactly related to captive portal
There was a problem hiding this comment.
@BKPepe
It is built into mesh11sd and is used by opendns when mesh11sd is present. Next versions of opennds will require it. It could be built into opennds - it is not huge - but as there seems to be a demand for it as a standalone utility (see the forum thread), this PR was raised.
There was a problem hiding this comment.
What submenu would you suggest?
There was a problem hiding this comment.
Thinking about it, yes, it makes more sense to set SUBMENU:=Wireless
|
In my humble opinion, we should not add more packages to the routing repository as there is a long term goal to migrate/move all this packages which we have to packages repository, where more ppl are active |
|
@BKPepe Perhaps if we could clean up the points you have raised here, then when we are happy, close this and resubmit to the main packages repository? |
|
@GeorgeSapkin what do you think? |
| # This is free software, licensed under the GNU General Public License v2. | ||
| # See /LICENSE for more information. |
There was a problem hiding this comment.
I think SPDX identifier is enough.
There was a problem hiding this comment.
I removed the two superfluous lines.
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_MAINTAINER:=Rob White <rob@blue-wave.net> | ||
| PKG_LICENSE:=GPL-2.0-or-later |
There was a problem hiding this comment.
Seems like it should GPL-2.0-or-only as per the repo.
| Detects WiFi chipset + driver capabilities. | ||
| It provides a stand alone script to detect details of the physical wireless hardware without requiring the radios to be enabled. | ||
| There are no dependencies over and above the basic OpenWrt flash image. | ||
| It is based on functionality originally built into the apmond daemon and incorporated into the OpenNDS and Mesh11sd packages. | ||
| This package provides a json formatted output to the terminal screen and in the file /tmp/wifidetect |
There was a problem hiding this comment.
This should probably be wrapped at ~70 characters for the menuconfig.
There was a problem hiding this comment.
I have re-written it in a less verbose style and kept the lines short.
I agree that it makes more sense to add this to packages instead. |
Maintainer: Rob White rob@blue-wave.net Compile tested: All Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, mips_24kc, aarch64_cortex-a53; On 24.10, 25.12 and master/snapshot. Description: wifi-chipset-detect (1.0.0) This is a new package that reports in json format the chipset and driver capabilities of installed wireless hardware. Developed originally for use where Captive Portal and Mesh Backhaul networks are being built. It provides a stand alone script to detect details of the physical wireless hardware without requiring the radios to be enabled. There are no dependencies over and above the basic OpenWrt flash image. It is based on functionality built into the OpenNDS and Mesh11sd packages. The json formatted output is displayed on the terminal screen. It is also written to the file /tmp/wifidetect. This version does not require the Captive Portal or Mesh network to be running. Full details can be seen here: https://github.com/openNDS/wifi-chipset-detect Signed-off-by: Rob White <rob@blue-wave.net>
|
@BKPepe @GeorgeSapkin |
|
@BKPepe @GeorgeSapkin |
|
@BKPepe |
Maintainer: Rob White rob@blue-wave.net
Compile tested: All
Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, mips_24kc,
aarch64_cortex-a53; On 24.10, 25.12 and master/snapshot.
Description: wifi-chipset-detect (1.0.0)
This is a new package that reports in json format the chipset
and driver capabilities of installed wireless hardware.
Developed originally for use where Captive Portal
and Mesh Backhaul networks are being built.
It provides a stand alone script to detect details of the physical
wireless hardware without requiring the radios to be enabled.
There are no dependencies over and above the basic OpenWrt flash image.
It is based on functionality built into the OpenNDS and Mesh11sd packages.
The json formatted output is displayed on the terminal screen.
It is also written to the file /tmp/wifidetect.
This version does not require the Captive Portal
or Mesh network to be running.
Full details can be seen here:
https://github.com/openNDS/wifi-chipset-detect
Signed-off-by: Rob White rob@blue-wave.net