Skip to content

wifi-chipset-detect: new package#1158

Closed
bluewavenet wants to merge 1 commit intoopenwrt:masterfrom
openNDS:master
Closed

wifi-chipset-detect: new package#1158
bluewavenet wants to merge 1 commit intoopenwrt:masterfrom
openNDS:master

Conversation

@bluewavenet
Copy link
Copy Markdown
Contributor

@bluewavenet bluewavenet commented Feb 18, 2026

Maintainer: Rob White rob@blue-wave.net

Compile tested: All

Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, mips_24kc,
aarch64_cortex-a53; On 24.10, 25.12 and master/snapshot.

Description: wifi-chipset-detect (1.0.0)

This is a new package that reports in json format the chipset
and driver capabilities of installed wireless hardware.

Developed originally for use where Captive Portal
and Mesh Backhaul networks are being built.

It provides a stand alone script to detect details of the physical
wireless hardware without requiring the radios to be enabled.
There are no dependencies over and above the basic OpenWrt flash image.
It is based on functionality built into the OpenNDS and Mesh11sd packages.

The json formatted output is displayed on the terminal screen.
It is also written to the file /tmp/wifidetect.

This version does not require the Captive Portal
or Mesh network to be running.

Full details can be seen here:
https://github.com/openNDS/wifi-chipset-detect

Signed-off-by: Rob White rob@blue-wave.net

@bluewavenet
Copy link
Copy Markdown
Contributor Author

[warn] Commit body line 5 is longer than 75 characters (is 118):

Ooh. That's interesting....

[fail] First word after prefix in subject should not be capitalized

I guess there is a reason for everything....

@bluewavenet bluewavenet changed the title wifi-chipset-detect: New package wifi-chipset-detect: new package Feb 18, 2026
@bluewavenet
Copy link
Copy Markdown
Contributor Author

Comment thread wifi-chipset-detect/Makefile Outdated
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://codeload.github.com/opennds/wifi-chipset-detect/tar.gz/v$(PKG_VERSION)?
PKG_HASH:=2e4d60861df598dbb13e0133a7ccaa4efa2534c158ae92852d693791e0f206b7
PKG_BUILD_DIR:=$(BUILD_DIR)/wifi-chipset-detect-$(PKG_VERSION)
Copy link
Copy Markdown
Member

@BKPepe BKPepe Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already default. It can be removed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't follow. Which line is default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BKPepe
Ah! If you mean line 18 (PKG_SOURCE) then yes it is the default, BUT the next line (PKG_SOURCE_URL) is in the Github Codeload format for the release tag which has a leading letter "v".

As far as I can see, when PKG_SOURCE is not explicitly set, it falls back to deriving the filename from the last component of PKG_SOURCE_URL (after stripping the query ?).

In turn this would mean the unpacked directory and PKG_BUILD_DIR would be incorrect and the build would fail.
I tested this in the SDK and yes, it failed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PKG_BUILD_DIR:=$(BUILD_DIR)/wifi-chipset-detect-$(PKG_VERSION)

Copy link
Copy Markdown
Contributor Author

@bluewavenet bluewavenet Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see what you are saying, but when building with the SDK after deleting this line, I get:
ERROR: package/feeds/routing/wifi-chipset-detect failed to build.
If I put it back in, it builds fine.
Is this an SDK artefact, or something deeper?
If you are sure it is not needed here, then all well and good.

EDIT: CI is happy with it deleted, so I'm happy too 😆

Comment thread wifi-chipset-detect/Makefile Outdated
Comment thread wifi-chipset-detect/Makefile Outdated
include $(INCLUDE_DIR)/package.mk

define Package/wifi-chipset-detect
SUBMENU:=Captive Portals
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure, if this submenu is alright. Standalone tool to detect wifi chipset. Not exactly related to captive portal

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BKPepe
It is built into mesh11sd and is used by opendns when mesh11sd is present. Next versions of opennds will require it. It could be built into opennds - it is not huge - but as there seems to be a demand for it as a standalone utility (see the forum thread), this PR was raised.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What submenu would you suggest?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, yes, it makes more sense to set SUBMENU:=Wireless

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 20, 2026

In my humble opinion, we should not add more packages to the routing repository as there is a long term goal to migrate/move all this packages which we have to packages repository, where more ppl are active

@bluewavenet
Copy link
Copy Markdown
Contributor Author

@BKPepe
Yes, there are arguments that could be made for and against, but this PR is not the place for that.
I'm happy to follow your advice.

Perhaps if we could clean up the points you have raised here, then when we are happy, close this and resubmit to the main packages repository?

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Feb 21, 2026

@GeorgeSapkin what do you think?

Comment thread wifi-chipset-detect/Makefile Outdated
Comment on lines +3 to +4
# This is free software, licensed under the GNU General Public License v2.
# See /LICENSE for more information.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SPDX identifier is enough.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the two superfluous lines.

Comment thread wifi-chipset-detect/Makefile Outdated
PKG_RELEASE:=1

PKG_MAINTAINER:=Rob White <rob@blue-wave.net>
PKG_LICENSE:=GPL-2.0-or-later
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should GPL-2.0-or-only as per the repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Comment thread wifi-chipset-detect/Makefile Outdated
Comment on lines +34 to +38
Detects WiFi chipset + driver capabilities.
It provides a stand alone script to detect details of the physical wireless hardware without requiring the radios to be enabled.
There are no dependencies over and above the basic OpenWrt flash image.
It is based on functionality originally built into the apmond daemon and incorporated into the OpenNDS and Mesh11sd packages.
This package provides a json formatted output to the terminal screen and in the file /tmp/wifidetect
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be wrapped at ~70 characters for the menuconfig.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-written it in a less verbose style and kept the lines short.

@GeorgeSapkin
Copy link
Copy Markdown
Member

In my humble opinion, we should not add more packages to the routing repository as there is a long term goal to migrate/move all this packages which we have to packages repository, where more ppl are active

I agree that it makes more sense to add this to packages instead.

Maintainer: Rob White rob@blue-wave.net

Compile tested: All

Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, mips_24kc,
aarch64_cortex-a53; On 24.10, 25.12 and master/snapshot.

Description: wifi-chipset-detect (1.0.0)

This is a new package that reports in json format the chipset
and driver capabilities of installed wireless hardware.

Developed originally for use where Captive Portal
and Mesh Backhaul networks are being built.

It provides a stand alone script to detect details of the physical
wireless hardware without requiring the radios to be enabled.
There are no dependencies over and above the basic OpenWrt flash image.
It is based on functionality built into the OpenNDS and Mesh11sd packages.

The json formatted output is displayed on the terminal screen.
It is also written to the file /tmp/wifidetect.

This version does not require the Captive Portal
or Mesh network to be running.

Full details can be seen here:
https://github.com/openNDS/wifi-chipset-detect

Signed-off-by: Rob White <rob@blue-wave.net>
@bluewavenet
Copy link
Copy Markdown
Contributor Author

@BKPepe @GeorgeSapkin
Moved to openwrt/packages

@bluewavenet bluewavenet closed this Mar 8, 2026
@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Mar 8, 2026

openwrt/packages#28715

@bluewavenet
Copy link
Copy Markdown
Contributor Author

bluewavenet commented Mar 18, 2026

@BKPepe @GeorgeSapkin
Maybe moving to openwrt/packages is not such a good idea as over there it seems to be a bit of a black hole...
It makes the idea of migrating everything from here somewhat undesirable....

@bluewavenet
Copy link
Copy Markdown
Contributor Author

@BKPepe
Weeks later and nothing has happened over in openwrt/packages
Kind of what I expected, same as I had a few years ago...
Where do we go from here?
Your advice would be appreciated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants