Skip to content

prometheus-node-exporter-lua: add test / skip test-version#29917

Merged
champtar merged 1 commit into
openwrt:masterfrom
champtar:disable-test-version-prom
Jul 5, 2026
Merged

prometheus-node-exporter-lua: add test / skip test-version#29917
champtar merged 1 commit into
openwrt:masterfrom
champtar:disable-test-version-prom

Conversation

@champtar

@champtar champtar commented Jul 4, 2026

Copy link
Copy Markdown
Member

📦 Package Details

Maintainer: me

Description:
test.sh is pretty basic and will not fail if one of the plugin fails, which is fine as most plugins will fail in CI anyway.

🧪 Run Testing Details

none (ci changes)

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@champtar champtar self-assigned this Jul 4, 2026
@champtar champtar force-pushed the disable-test-version-prom branch 2 times, most recently from b2b0dab to 53a1012 Compare July 5, 2026 07:44
@champtar champtar marked this pull request as draft July 5, 2026 07:48
@champtar

champtar commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

make package/prometheus-node-exporter-lua/compile V=99 -j1 works fine with a normal build env, need to try out the SDK to understand why it doesn't respect dependencies and tries to build packages from other arches (ltq-dsl-app depends on ltq-dsl-base which depends on @(TARGET_lantiq||TARGET_ipq40xx))

@champtar

champtar commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

We are executing the tests for each dependencies, seems wrong to me

realtek-poe: No executables in the package provided version 1.3.1
realtek-poe: Generic tests failed

@champtar champtar force-pushed the disable-test-version-prom branch from 53a1012 to cf5925f Compare July 5, 2026 10:38
test.sh is pretty basic and will not fail if one of the plugin fails,
which is fine as most plugins will fail in CI anyway.

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@champtar champtar force-pushed the disable-test-version-prom branch from cf5925f to 5abb7af Compare July 5, 2026 12:19
@champtar

champtar commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

CI now green without ltq-dsl, going to add it back and merge

@champtar champtar force-pushed the disable-test-version-prom branch from 5abb7af to e6a971e Compare July 5, 2026 15:16
@champtar champtar marked this pull request as ready for review July 5, 2026 15:16
@champtar champtar merged commit 4741715 into openwrt:master Jul 5, 2026
4 checks passed
@champtar champtar deleted the disable-test-version-prom branch July 5, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant