treewide: homogenize references to libfts for MUSL#29799
Merged
Conversation
Contributor
|
I assume this was tested on glibc? |
Member
Author
Do we have a CI/CD target build for |
Contributor
|
No. That’s why I asked |
Member
Author
Okay, doing a build now on |
pprindeville
force-pushed
the
fts-scrub
branch
2 times, most recently
from
d45a8f3 to
0c5f9a6
Compare
Member
Author
|
Hmm... Build errorsNot using the |
Member
Author
|
Opened separate issue openwrt/openwrt#23909 for |
Member
Author
This was a heavy lift, btw. |
Member
Author
|
Requires openwrt/openwrt#23919. |
commodo
approved these changes
Jun 23, 2026
This was referenced Jun 28, 2026
Member
Author
|
@neheb Stuck in limbo until the upstream fix in openwrt/ gets merged... |
Contributor
|
I don’t have merge access anywhere. Not sure what’s being asked of me. |
Member
Author
I can merge it once |
There was a problem hiding this comment.
Pull request overview
This PR standardizes how packages in this feed link against libfts when building on musl, replacing ad-hoc/patch-based approaches with a consistent TARGET_LDFLAGS += $(if $(CONFIG_USE_MUSL),-lfts) pattern (and adding the musl-fts dependency where needed).
Changes:
- Replace package-specific musl
-lftshandling with a consistentTARGET_LDFLAGSconditional across several packages. - Remove the
nnnmusl fts patch in favor of build-system linker flags. - Add/align
+USE_MUSL:musl-ftsdependency where required (e.g., python-selinux), and fix a small typo in tcpreplay’s description.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/nnn/patches/musl-fts.patch | Removes a patch that injected -lfts into upstream LDLIBS, shifting responsibility to OpenWrt build flags. |
| utils/nnn/Makefile | Bumps release and adds musl-conditional -lfts via TARGET_LDFLAGS. |
| utils/exfatprogs/Makefile | Bumps release and adds musl-conditional -lfts via TARGET_LDFLAGS. |
| net/tcpreplay/Makefile | Bumps release, fixes “briding” typo, and standardizes musl -lfts handling via TARGET_LDFLAGS. |
| net/nfdump/Makefile | Bumps release and adjusts musl -lfts handling (but also drops --as-needed). |
| lang/python/python-selinux/Makefile | Bumps release and adds musl-fts dependency for musl builds. |
| admin/fluent-bit/Makefile | Bumps release and gates -lfts on musl while preserving -latomic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| endef | ||
|
|
||
| TARGET_LDFLAGS += -Wl,--as-needed $(if $(CONFIG_USE_MUSL),-lfts) | ||
| TARGET_LDFLAGS += $(if $(CONFIG_USE_MUSL),-lfts) |
Getting segfault because stack size is inadequate. Fixes: openwrt#29777 Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
Member
Author
|
@dhrm1k: Integrated the CI/CD fix. Thanks |
Member
Author
Still failing, however. Hell and damnation. |
The way we use -lfts isn't particularly consistent. There's no reason it shouldn't be. glibc users shouldn't have to deal with someone else's lack of rigor. Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
Member
Author
|
@dhrm1k @commodo: different platforms are failing differently, sometimes not even in the packages that are being modified. This points to general instability in the CI/CD tests or the test environment. Further, all of the failing platforms are in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @tpetazzoni, @flyn-org, @dangowrt, @BKPepe, @neheb, @nmeyerhans
Description:
The way we use
-lftsisn't particularly consistent. There's no reason it shouldn't be.glibcusers shouldn't have to deal with someone else's lack of rigor.🧪 Run Testing Details
✅ Formalities