Skip to content

prosody: update to 0.12.4#28177

Merged
BKPepe merged 1 commit intomasterfrom
copilot/update-prosody-to-0124
Apr 26, 2026
Merged

prosody: update to 0.12.4#28177
BKPepe merged 1 commit intomasterfrom
copilot/update-prosody-to-0124

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 26, 2025

📦 Package Details

Maintainer: @theilm
(You can find this by checking the history of the package Makefile.)

Description:
Updates Prosody XMPP server from EOL version 0.11.13 to 0.12.4. The 0.11.x branch reached end-of-life on 2024-08-14.

Changes:

  • PKG_VERSION: 0.11.13 → 0.12.4
  • PKG_HASH: Updated for new tarball

Release notes: https://blog.prosody.im/prosody-0.12.4-released/


🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/prosody/prosody/tags
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)
  • prosody.im
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
    • Triggering command: /usr/bin/wget wget -q REDACTED (dns block)
    • Triggering command: /usr/bin/curl curl -sL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>request prosody update to 0.12.4</issue_title>
<issue_description>is it possible to upgrade prosody to latest version?

Since 2024-08-14 the Prosody 0.11.x branch reached end of life...

see https://groups.google.com/d/msgid/prosody-users/ZsdHWTXE_f0zD51X%40diploria.zash.se

best regards

Denis</issue_description>

<agent_instructions>Try to update prosody to its latest version, only one single commit and put release Notes URL to the description</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update Prosody to version 0.12.4 prosody: update to 0.12.4 Dec 26, 2025
Copilot AI requested a review from BKPepe December 26, 2025 10:48
@BKPepe BKPepe marked this pull request as ready for review December 26, 2025 10:51
Copilot AI review requested due to automatic review settings December 26, 2025 10:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Prosody XMPP server package from the end-of-life version 0.11.13 to version 0.12.4. The 0.11.x branch reached end-of-life on 2024-08-14, making this update necessary for continued security and support.

Key changes:

  • Version bump from 0.11.13 to 0.12.4
  • Updated package hash for the new tarball

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Neustradamus

This comment was marked as low quality.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Dec 26, 2025

Still it needs to be tested on real device.

@GeorgeSapkin
Copy link
Copy Markdown
Member

I was thinking of having a hypothetical dependabot plugin that could renovate the packages automatically, but haven't looked into the possibility of doing that. There's this tool from @sdwalker that figures out all the versions already, unfortunately I haven't seen any sources. So something like this, plus calculating hashes and opening a PR. Having Copilot do that is a bit of an overkill.

@wehagy
Copy link
Copy Markdown
Member

wehagy commented Dec 26, 2025

I was thinking of having a hypothetical dependabot plugin that could renovate the packages automatically

I have thought about this a little in the past, because I have my own script for netbird that does some of it: it makes the commit for me, pushes a new branch, and builds the image. I want that script to run the tests and open the PR for me too, those 2 steps are manual today. The test step is the bigger problem for me, I don't just check whether the package runs, I read the logs, look at recent PRs/commits, documentation, changelogs, and upstream issues, etc. After all that I decide whether to open the PR (I don't know if it's the "right way" and I don't want everyone to follow the same workflow, every maintainer has their own).

That said, I'm afraid we might just update two lines and merge without "proper testing" (whatever that means). I also don't want anyone touching netbird without my ACK within a reasonable time for me to review (I think something like 1-2 weeks, but that's just a number I pulled from my head, it could be 1 day or less for critical bugs or security fixes, in which case I don't need to review).

To be honest, though, I think any package without a maintainer to ACK it needs to go to oblivion, but that's a discussion for another day.

So it's good to have some discussion, before or after the implementation, to figure out the right direction and update the rules accordingly.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Dec 29, 2025

Having Copilot do that is a bit of an overkill.

Yes, the use of Copilot would indeed be overkill for this — like shooting sparrows with a cannon — but theoretically, it could be used in such a way that Copilot creates a pull request for simpler tasks. Within GitHub Actions, it could then be compiled, and based on that test, we could determine whether it runs or at least verify the version output using --version. At the same time, users would be able to download the package and test it on a real device. I understand that some people don’t want to use master/snapshot builds (and honestly, Turris OS doesn’t really care about that either), so for now, I’m testing certain things only on stable versions. :(

@hnyman
Copy link
Copy Markdown
Contributor

hnyman commented Mar 3, 2026

Why is this now as a branch in the packages repo?
@BKPepe

Apparently something from December, but now it surfaces now March as a new branch in the packages repo ?

perus@ub2510:/OpenWrt/r7800/feeds/packages$ git pull
remote: Enumerating objects: 172, done.
remote: Counting objects: 100% (157/157), done.
remote: Compressing objects: 100% (82/82), done.
remote: Total 101 (delta 38), reused 0 (delta 0), pack-reused 0 (from 0)
Receiving objects: 100% (101/101), 16.10 KiB | 317.00 KiB/s, done.
Resolving deltas: 100% (38/38), completed with 20 local objects.
From https://git.openwrt.org/feed/packages
   b543052ae..e026ce0f0  master     -> origin/master
 * [new branch]          copilot/update-prosody-to-0124 -> origin/copilot/update-prosody-to-0124
Updating b543052ae..e026ce0f0

Release notes: https://blog.prosody.im/prosody-0.12.4-released/

Co-authored-by: BKPepe <4096468+BKPepe@users.noreply.github.com>
@BKPepe BKPepe force-pushed the copilot/update-prosody-to-0124 branch from 88b4f79 to 5bad056 Compare March 3, 2026 16:20
@Neustradamus

This comment was marked as low quality.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Apr 26, 2026

@hnyman Sorry for the late reply. I wasn't ignoring you, but I was on vacation for more than 2 months and I am just getting to it now.
Actually, you are right. The branch is indeed in this repository, not in the forked one. This is simply how Copilot behaves, and there is no direct way to move it to my own fork through its interface.

Honestly, since this PR has been sitting here since December and nobody has gotten around to reviewing it, it seems like not many people are interested in this package anyway. What if we just #yolo merge it into master and see what happens? Maybe it gets tested in the wild, maybe it breaks things even more, or maybe it turns out just fine. Lets see.

@BKPepe BKPepe merged commit f4d305b into master Apr 26, 2026
3 of 4 checks passed
@BKPepe BKPepe deleted the copilot/update-prosody-to-0124 branch April 26, 2026 20:21
@Neustradamus

This comment was marked as low quality.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Apr 26, 2026

Answered here - #25464 (comment).

No need to have additional space to discuss it. Closing, locking.

@openwrt openwrt locked as resolved and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request prosody update to 0.12.4

7 participants