Skip to content

libopen62541: preserve symlinks on install#28170

Merged
BKPepe merged 1 commit intoopenwrt:masterfrom
BrelJordan:fix_mk_libopen62541
Dec 29, 2025
Merged

libopen62541: preserve symlinks on install#28170
BKPepe merged 1 commit intoopenwrt:masterfrom
BrelJordan:fix_mk_libopen62541

Conversation

@BrelJordan
Copy link
Copy Markdown

fix libopen62541 Makefile to copy lib without following symlinks.

@GeorgeSapkin
Copy link
Copy Markdown
Member

From this description alone it's not clear how exactly this saves space.

And you have to adjust the commit title to follow the 50/75 rule.

@BrelJordan
Copy link
Copy Markdown
Author

BrelJordan commented Dec 26, 2025

I updated the commit message to comply with the 50/75 rule and added a clearer description of what the changes do.

$(INSTALL_BIN) follows symlinks, causing the .so to be copied multiple times.
Use $(CP) instead to preserve symlinks and cut package size by ~2/3.
OpenWrt libraries don’t need to be executable, so $(INSTALL_BIN) isn’t required.

@BrelJordan BrelJordan changed the title libopen62541: save space on target, copy library and symlinks libopen62541: reduce package size by preserving symlinks on install Dec 26, 2025
$(INSTALL_BIN) follows symlinks, causing the .so to be copied multiple times.
Use $(CP) instead to preserve symlinks and cut package size by ~2/3.
OpenWrt libraries don’t need to be executable, so $(INSTALL_BIN) isn’t required.

Signed-off-by: Jordan Ngako <jordanfalken@gmx.de>
@BrelJordan BrelJordan changed the title libopen62541: reduce package size by preserving symlinks on install libopen62541: preserve symlinks on install Dec 26, 2025
@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Dec 29, 2025

$(INSTALL_BIN) follows symlinks, causing the .so to be copied multiple times.
Use $(CP) instead to preserve symlinks and cut package size by ~2/3.

Ideally, it should be like this: #23512 or even like this openwrt/openwrt@38b22b1

I think, we need one more round of #9233 , because it looks like a few packages again are doing it:-)

But fine by me. Merging!

@BKPepe BKPepe merged commit 1c1af85 into openwrt:master Dec 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants