[openwrt-21.02] addrwatch: Various fixes#16125
Merged
neheb merged 1 commit intoopenwrt:openwrt-21.02from Jul 15, 2021
Merged
Conversation
Makefile changes include: * Remove USE_UCLIBC, as uclibc is no longer supported * Package output modules * Move main binary (back) to /usr/sbin, as it is system administration related and requires superuser privileges New patches: * 003-add-space-for-null-byte.patch - from fln/addrwatch@374cfd2 * 004-more-specific-library-linking.patch - from fln/addrwatch@27b57d9 * 005-use-c99-format-macro-constants.patch - from fln/addrwatch#28 Init script changes include: * Change from explicit disable to explicit enable, so that the service is disabled by default and on first install * Set config option default values to default values of the main binary * Fix command-line option names and format (from https://forum.openwrt.org/t/cant-start-addrwatch-service/60499/3) * Always use the --quiet command-line option, as the procd instance is not configured to capture stdout/stderr * Change the syslog config option to start the syslog output module Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit 31ae85b)
Contributor
|
Thank you for your effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: @oskar456
Compile tested: none (cherry picked from #15899)
Run tested: none
Description:
Makefile changes include:
Remove
USE_UCLIBC, as uclibc is no longer supportedPackage output modules
Move main binary (back) to /usr/sbin, as it is system administration related and requires superuser privileges
New patches:
003-add-space-for-null-byte.patch - from fln/addrwatch@374cfd2
004-more-specific-library-linking.patch - from fln/addrwatch@27b57d9
005-use-c99-format-macro-constants.patch - from Use C99 format macro constants for timestamp and vlan_tag fln/addrwatch#28
Init script changes include:
Change from explicit disable to explicit enable, so that the service is disabled by default and on first install
Set config option default values to default values of the main binary
Fix command-line option names and format (from https://forum.openwrt.org/t/cant-start-addrwatch-service/60499/3)
Always use the
--quietcommand-line option, as the procd instance is not configured to capture stdout/stderrChange the syslog config option to start the syslog output module
Signed-off-by: Jeffery To jeffery.to@gmail.com
(cherry picked from commit 31ae85b)