wifi: mt76: use hrtimer_setup() in mt76x02u beacon init #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping @nbd168 |
Replace the two-step hrtimer initialization pattern with a single consolidated call to hrtimer_setup(). The legacy approach of calling hrtimer_init() followed by manual assignment to timer.function is deprecated. The new hrtimer_setup() helper atomically initializes the timer and assigns the callback function in one operation, eliminating the race-prone intermediate state where the timer is initialized but lacks a handler. Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the two-step hrtimer initialization pattern with a single consolidated call to hrtimer_setup().
The legacy approach of calling hrtimer_init() followed by manual assignment to timer.function is deprecated.
The new hrtimer_setup() helper atomically initializes the timer and assigns the callback function in one operation,
eliminating the race-prone intermediate state where the timer is initialized but lacks a handler.
The patch allows for correct compilation on kernel 6.18.
Link: https://lore.kernel.org/all/71fbc442aee9a9e892e475f3bbf8f368c6692a55.1738746872.git.namcao@linutronix.de