build: fix csstidy breaking css#8000
Open
AndyChiang888 wants to merge 1 commit intoopenwrt:masterfrom
Open
Conversation
AndyChiang888
force-pushed
the
csstidy
branch
from
ee9db57 to
836f621
Compare
AndyChiang888
changed the title
css is broken by csstidy, like 788e470. add preserve_css to avoid this. Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
AndyChiang888
force-pushed
the
csstidy
branch
from
836f621 to
33479b0
Compare
AndyChiang888
changed the title
Contributor
|
Broken how, and where? |
Contributor
Author
new code added in 788e470#diff-c82ac665c416f2f417fc53e801e86b777bfedc9ff5c01e427f956d0103f79f3a: css after tidy Except .cbi-title div {}, all others are missing After adding preserve_css: |
Contributor
I see. Thank you. It would be better to address the original CSS instead of amending csstidy parameters for many of those -moz and -webkit properties. Each of those 'invalid' properties is handled by browsers. E.g. the appearance property mentions the -moz and -webkit versions (as being old). Some messages appear to be misleading also:
Those properties don't disappear, they just appear elsewhere you don't expect.
Run this chunk through tidy - they all come through, just slightly modified. |
Contributor
Author
|
There is another issue. Network has been reduced a lot. With --preserve_css=true, cascade.css after tidy is the same as cascade.css without tidy, both are normal: 
|
Contributor
Author
|
@systemcrash Do you have any thoughts on this issue? |
Contributor
|
It's not a big deal, but if we can find which properties are responsible, they can be adjusted. |
|
@AndyChiang888: Good catch about "Network has been reduced a lot.". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css is broken by csstidy, like 788e470. add preserve_css to avoid this.
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile