reusable_build: fix toolchain file parsing#87
Merged
robimarko merged 1 commit intoopenwrt:mainfrom Jan 21, 2026
Merged
Conversation
Currently, we are echoing TOOLCHAIN_FILE as a string instead of its content to set TOOLCHAIN_NAME variable, which will make the CI fail with: Toolchain directory 'TOOLCHAIN_FILE/toolchain-*' does not exist. As TOOLCHAIN_NAME variable value will be exactly: "TOOLCHAIN_FILE" which obviously is not correct. Fixes: 6ed0816 ("CI: reusable-build: support both .xz and .zst compression") Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Failed checksIssues marked with an ❌ are failing checks. Commit 855dde9
For more details, see the full job log. Something broken? Consider providing feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are echoing TOOLCHAIN_FILE as a string instead of its content to set TOOLCHAIN_NAME variable, which will make the CI fail with: Toolchain directory 'TOOLCHAIN_FILE/toolchain-*' does not exist.
As TOOLCHAIN_NAME variable value will be exactly: "TOOLCHAIN_FILE" which obviously is not correct.
Fixes: 6ed0816 ("CI: reusable-build: support both .xz and .zst compression")