Skip to content

build-on-comment: migrate from openwrt.git#82

Merged
aparcar merged 1 commit intoopenwrt:mainfrom
aparcar:build-on-comment
Jan 16, 2026
Merged

build-on-comment: migrate from openwrt.git#82
aparcar merged 1 commit intoopenwrt:mainfrom
aparcar:build-on-comment

Conversation

@aparcar
Copy link
Member

@aparcar aparcar commented Jan 15, 2026

Let's maintain the script over here, I should have added it here to
begin with. While at it, rework to use the PR message as trigger, not
any comments. This reduces the amount of running CI jobs and also allows
but PR creator and maintainers (by modifing the PR message) to trigger
such job.

@aparcar
Copy link
Member Author

aparcar commented Jan 15, 2026

related openwrt/openwrt#21548

@Djfe
Copy link

Djfe commented Jan 15, 2026

Hi @aparcar,

great idea to move this action here 👍

I was a bit confused about this action in the past and could never get a hold of you sadly, so I'm asking here, even if it's a bit off-topic:

May I ask about the implications of this change?
I kept on getting mails from some of my comments on pull requests:
subject: [openwrt/openwrt] Run cancelled: Build on Comment - main (226981d)
even though these comments didn't intend to trigger a build - they were a regular comment.

Anyways I was never able to trigger an actual build by commenting, @hauke wasn't able to trigger a build either.

  1. Is this action broken somehow or was I (and maybe hauke) never in the "build-on-comment" group. (I have no clue how/where to check this 😅)

  2. Will this limit the build trigger to the pr author? (the commit message says "instead")

I'm just curious. looking forward to your answer 😊

@aparcar
Copy link
Member Author

aparcar commented Jan 15, 2026

Yikes, this one shouldn't send any email.

Yes, it limits the command to the author, which I find an okay solution.

Not sure why this never worked for you or Hauke, at least Hauke should be in that group

Let's maintain the script over here, I should have added it here to
begin with. While at it, rework to use the PR message as trigger, not
any comments. This reduces the amount of running CI jobs and also allows
but PR creator and maintainers (by modifing the PR message) to trigger
such job.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar
Copy link
Member Author

aparcar commented Jan 15, 2026

Reworked to use PR message instead of comments, much cleaner.

@Djfe
Copy link

Djfe commented Jan 15, 2026

could you please test whether your current build on comment still works for you atm.?
openwrt/openwrt#21511

@robimarko
Copy link
Contributor

I also get the constant: Run cancelled: Build on Comment after each my comment with the existing workflow which is kind of annoying

@aparcar aparcar merged commit ae70c77 into openwrt:main Jan 16, 2026
1 check passed
@aparcar
Copy link
Member Author

aparcar commented Jan 16, 2026

I also get the constant: Run cancelled: Build on Comment after each my comment with the existing workflow which is kind of annoying

I'm very sorry, I never received such messages. I merged it, hoping to work better from now on.

@aparcar aparcar deleted the build-on-comment branch January 16, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants