build-on-comment: migrate from openwrt.git#82
Conversation
|
related openwrt/openwrt#21548 |
|
Hi @aparcar, great idea to move this action here 👍 I was a bit confused about this action in the past and could never get a hold of you sadly, so I'm asking here, even if it's a bit off-topic: May I ask about the implications of this change? Anyways I was never able to trigger an actual build by commenting, @hauke wasn't able to trigger a build either.
I'm just curious. looking forward to your answer 😊 |
|
Yikes, this one shouldn't send any email. Yes, it limits the command to the author, which I find an okay solution. Not sure why this never worked for you or Hauke, at least Hauke should be in that group |
Let's maintain the script over here, I should have added it here to begin with. While at it, rework to use the PR message as trigger, not any comments. This reduces the amount of running CI jobs and also allows but PR creator and maintainers (by modifing the PR message) to trigger such job. Signed-off-by: Paul Spooren <mail@aparcar.org>
5d010c2 to
9879f69
Compare
|
Reworked to use PR message instead of comments, much cleaner. |
|
could you please test whether your current build on comment still works for you atm.? |
|
I also get the constant: Run cancelled: Build on Comment after each my comment with the existing workflow which is kind of annoying |
I'm very sorry, I never received such messages. I merged it, hoping to work better from now on. |
Let's maintain the script over here, I should have added it here to
begin with. While at it, rework to use the PR message as trigger, not
any comments. This reduces the amount of running CI jobs and also allows
but PR creator and maintainers (by modifing the PR message) to trigger
such job.