[cleanup] Remove deprecated code marked for 1.2.0 release#1182
[cleanup] Remove deprecated code marked for 1.2.0 release#1182Viscous106 wants to merge 2 commits intoopenwisp:masterfrom
Conversation
53d8044 to
ca459d1
Compare
ca459d1 to
27f9893
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
@Viscous106 why did you close this? |
|
Hi @nemesifier, apologies for closing this so out of the blue. I was hitting persistent CI failures despite the tests passing locally, so I stepped back to debug my environment. I have since read Discussion #1181 and fixed my setup. I am ready to resolve the remaining checks now, so I will reopen this. |
|
Hi @nemesifier, I have fixed the linting and environment issues we discussed. However, to ensure a clean commit history and avoid the confusion caused by the previous branch reset, I have opened a fresh PR with the finalized fixes. Superseded by #1190. Thanks! |
Summary
This PR removes multiple instances of deprecated code that were marked for removal in release 1.2.0 (or earlier). This cleans up technical debt in the config, tasks, and controller views.
Changes
config.py): Removed the deprecatedget_cached_argscompatibility wrapper.tasks.py): Removed the deprecatedinvalidate_device_checksum_view_cachetask.views.py): Removed legacy support forstatus="running"inDeviceReportStatusView. The modernstatus="applied"logic is preserved.test_controller.py): Removedtest_device_report_status_runningwhich tested the deprecated "running" status.Verification
python tests/manage.py test openwisp_controller.configtest_device_report_status_appliedstill passes and the controller handles status updates correctly.