feat: split keccak chip into xorin + keccakf

[shuklaayush]

Closes INT-5017

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will degrade performance by 83.29%

_{Comparing develop-new-keccak (6f0f247) with develop-v1.6.0 (6dc3800)¹}

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 9 regressed benchmarks
✅ 15 untouched benchmarks
⏩ 36 skipped benchmarks²

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	WallTime	benchmark_execute_metered[quicksort]	9 ms	45.8 ms	-80.27%
❌	WallTime	benchmark_execute_metered[sha256]	9.3 ms	45.2 ms	-79.41%
❌	WallTime	benchmark_execute_metered[keccak256]	11.1 ms	49.9 ms	-77.75%
❌	WallTime	benchmark_execute_metered[keccak256_iter]	71.7 ms	192.1 ms	-62.7%
❌	WallTime	benchmark_execute_metered[fibonacci_recursive]	16.9 ms	53.7 ms	-68.48%
❌	WallTime	benchmark_execute_metered[bubblesort]	11.3 ms	47.8 ms	-76.45%
❌	WallTime	benchmark_execute_metered[fibonacci_iterative]	14.3 ms	50.1 ms	-71.44%
❌	WallTime	benchmark_execute_metered[revm_transfer]	24.9 ms	61.3 ms	-59.4%
❌	WallTime	benchmark_execute_metered[revm_snailtracer]	7.3 ms	43.9 ms	-83.29%

Footnotes

1. No successful run was found on develop-v1.6.0 (cb19091) during the generation of this report, so 95fdcd5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[jonathanpwang]

LGTM to merge into develop branch. We will fix lint and add more comprehensive test suite after merging.

[Copilot]

Pull request overview

This PR refactors the keccak256 circuit implementation by splitting it into two separate operations: xorin (for XOR-ing input into state) and keccakf (for the keccak-f permutation). This architectural change separates concerns and provides better modularity.

Changes:

• Split monolithic keccak256 opcode into XORIN and KECCAKF opcodes with separate transpiler handling
• Refactored guest library to implement keccak256 using the new primitives with optimized state management
• Created separate AIRs and chips for xorin and keccakf operations, plus a periphery chip for keccakf permutation
• Updated CUDA kernels to support the new architecture

Reviewed changes

Copilot reviewed 53 out of 56 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
extensions/keccak256/transpiler/src/lib.rs	Split opcode enum into KeccakfOpcode and XorinOpcode with updated transpiler logic
extensions/keccak256/guest/src/lib.rs	Implemented new xorin/keccakf primitives and refactored keccak256 to use them
extensions/keccak256/circuit/src/lib.rs	Reorganized module structure for new chip architecture
extensions/keccak256/circuit/src/xorin/*	New xorin chip implementation (air, columns, trace, tests)
extensions/keccak256/circuit/src/keccakf_op/*	New keccakf operation chip
extensions/keccak256/circuit/src/keccakf_perm/*	New keccakf permutation periphery chip
extensions/keccak256/circuit/cuda/*	Updated CUDA kernels for new architecture
guest-libs/keccak256/tests/lib.rs	Updated tests to use builder pattern with feature flags

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

group	app.proof_time_ms	app.cycles	app.cells_used	leaf.proof_time_ms	leaf.cycles	leaf.cells_used
verify_fibair	276	322,610	0	-	-	-
fibonacci	1,034	1,500,265	0	-	-	-
regex	2,342	4,137,877	0	-	-	-
ecrecover	762	124,173	0	-	-	-
pairing	1,475	1,745,757	0	-	-	-

Commit: 6f0f247

Benchmark Workflow

[jonathanpwang]

Actually I'm going to close this PR because I will rebase develop-v1.6.0 onto develop-new-keccak for history purposes