Skip to content

feat: remove memory access adapters: CPU Boundary AIR, initialize/finalize memory#2318

Merged
jonathanpwang merged 22 commits intofeat/access-adapter-removalfrom
feat/remove-mem-access2
Jan 20, 2026
Merged

feat: remove memory access adapters: CPU Boundary AIR, initialize/finalize memory#2318
jonathanpwang merged 22 commits intofeat/access-adapter-removalfrom
feat/remove-mem-access2

Conversation

@Maillew
Copy link
Copy Markdown
Contributor

@Maillew Maillew commented Dec 11, 2025

Closes INT-5723, INT-5724, INT-5726

@github-actions
Copy link
Copy Markdown

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 229 322,610 2,058,654 - - -
fibonacci 1,010 1,500,209 2,100,402 - - -
regex 2,331 4,137,502 17,695,216 - - -
ecrecover 716 122,859 2,265,100 - - -
pairing 1,456 1,745,742 25,408,302 - - -

Commit: 60d1d19

Benchmark Workflow

@Maillew Maillew force-pushed the feat/remove-mem-access2 branch from d0e7bae to 9d0bea8 Compare December 12, 2025 22:45
@Maillew Maillew changed the title [TMP] remove memory access adapters remove memory access adapters: CPU Boundary AIR, initialize/finalize memory Dec 12, 2025
@Maillew Maillew changed the base branch from develop-v1.6.0 to feat/access-adapter-removal December 12, 2025 22:56
@Maillew Maillew changed the title remove memory access adapters: CPU Boundary AIR, initialize/finalize memory feat: remove memory access adapters: CPU Boundary AIR, initialize/finalize memory Dec 12, 2025
@Maillew Maillew requested a review from shuklaayush December 12, 2025 23:34
@Maillew Maillew force-pushed the feat/remove-mem-access2 branch 2 times, most recently from f937ae0 to 3706b09 Compare December 18, 2025 18:44
@Maillew Maillew marked this pull request as ready for review December 18, 2025 19:02
@Maillew Maillew force-pushed the feat/access-adapter-removal branch from df72623 to e5cca45 Compare December 18, 2025 19:46
@Maillew Maillew force-pushed the feat/remove-mem-access2 branch from 2051624 to a5814d4 Compare December 18, 2025 20:14
Comment thread crates/vm/src/arch/config.rs Outdated
Comment thread crates/vm/src/arch/testing/cpu.rs
Comment thread crates/vm/src/system/memory/persistent.rs Outdated
Comment thread crates/vm/src/arch/config.rs Outdated
Comment thread crates/vm/src/system/memory/persistent.rs Outdated
Comment thread extensions/rv32im/circuit/src/loadstore/tests.rs
Comment on lines +248 to +250
use std::collections::BTreeMap;
let mut chunk_map: BTreeMap<(u32, u32), ([u32; BLOCKS_PER_CHUNK], [F; CHUNK])> =
BTreeMap::new();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this by just a par_iter on a vector or do we need a btreemap here? btreemaps are slow

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved: 5bd398c

note, have to do it in two passes, because of race conditions if accessing the same chunk

@Maillew Maillew requested a review from shuklaayush December 19, 2025 23:11
@jonathanpwang jonathanpwang force-pushed the feat/access-adapter-removal branch 2 times, most recently from 6b04b45 to 95b9cdf Compare January 12, 2026 00:53
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 20, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
jpw-axiom pushed a commit that referenced this pull request Mar 21, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 23, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
shuklaayush pushed a commit that referenced this pull request Mar 23, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 23, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 24, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 25, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 25, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
shuklaayush pushed a commit that referenced this pull request Mar 25, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
shuklaayush pushed a commit that referenced this pull request Mar 26, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 26, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 1, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 1, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 1, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 1, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 1, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
jonathanpwang added a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
shuklaayush pushed a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
branch-rebase-bot Bot pushed a commit that referenced this pull request Apr 2, 2026
…alize memory (#2318)

Closes INT-5723, INT-5724, INT-5726

---------

Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants