Skip to content

Conversation

@CFenner
Copy link
Member

@CFenner CFenner commented Nov 6, 2025

New Viessmann EUDataAct-Data Points are missing
#153184

New Viessmann EUDataAct-Data Points are missing
#153184
@CFenner
Copy link
Member Author

CFenner commented Nov 6, 2025

@Trebron24 could you give change permission on this PR?

@CFenner CFenner changed the title Create Viessmann CU401B G (Vitocal 300-G).json chore(testdata): add Vitocal 300G sample data Nov 6, 2025
@Trebron24
Copy link

Trebron24 commented Nov 6, 2025 via email

@CFenner
Copy link
Member Author

CFenner commented Nov 7, 2025

Usually when you open a pr there is a checkbox. But maybe as I opened the PR, it is not possible. Could you create a PR from your branch yourself?

Bildschirmfoto 2025-11-07 um 08 33 52

@Trebron24
Copy link

Sorry for not really be an expert in Github. I have tried to create a pull request but I'm not sure if the json-file is now visable for you. If not, a detailled instruction how to create such a pr would be very helpful.

@CFenner CFenner marked this pull request as ready for review November 20, 2025 07:29
@lackas
Copy link

lackas commented Jan 22, 2026

Hi @CFenner, I noticed this PR adds test data for the same device I have. I've submitted PR #688 which includes both test data (Vitocal300G_CU401B.json) and implementations for many of the 300-G features (COP, compressor power, refrigerant sensors, cooling circuits, etc.).

Should we consolidate the test data, or are these intended to capture different device configurations?

@lackas
Copy link

lackas commented Jan 22, 2026

I compared the test data from this PR to mine in PR #688:

PR #645 (yours) PR #688 (mine)
Total features 213 188

Features in yours but not mine (25):

Category Features
Gateway gateway.bmuconnection, gateway.devices, gateway.wifi
Device info device.identification, device.information, device.heatingCircuitId, device.configuration.measurementWeight, device.messages.status.raw, device.power.battery
Zigbee device.zigbee.lqi, device.zigbee.parent.id/rx/tx
Floor Heating (FHT) fht.configuration.*, fht.operating.modes.active, fht.valve, fht.valve.state
TRV trv.childLock, trv.mountingMode, trv.temperature, trv.valve.position
Circuit names heating.circuits.0.name, heating.circuits.2.name

Features in mine but not yours: None

Your data is a superset - same core 300-G heat pump features plus Zigbee accessories (TRVs, floor heating thermostats). My PR #688 includes implementations for many of the heat pump features but not the Zigbee accessories.

Options:

  1. Use your richer test data and add my implementations
  2. Keep both test files for different device configurations
  3. Merge both into one comprehensive test file

Let me know how you'd like to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants