-
Notifications
You must be signed in to change notification settings - Fork 112
chore(testdata): add Vitocal 300G sample data #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New Viessmann EUDataAct-Data Points are missing #153184
|
@Trebron24 could you give change permission on this PR? |
|
What kind of permission do you need?Von meinem iPhone gesendetAm 06.11.2025 um 19:36 schrieb Christopher Fenner ***@***.***>:CFenner left a comment (openviess/PyViCare#645)
@Trebron24 could you give change permission on this PR?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Sorry for not really be an expert in Github. I have tried to create a pull request but I'm not sure if the json-file is now visable for you. If not, a detailled instruction how to create such a pr would be very helpful. |
|
Hi @CFenner, I noticed this PR adds test data for the same device I have. I've submitted PR #688 which includes both test data ( Should we consolidate the test data, or are these intended to capture different device configurations? |
|
I compared the test data from this PR to mine in PR #688:
Features in yours but not mine (25):
Features in mine but not yours: None Your data is a superset - same core 300-G heat pump features plus Zigbee accessories (TRVs, floor heating thermostats). My PR #688 includes implementations for many of the heat pump features but not the Zigbee accessories. Options:
Let me know how you'd like to proceed. |

New Viessmann EUDataAct-Data Points are missing
#153184