Changes and improvements on rule-based Filipino phonemizer#2144
Open
UtaUtaUtau wants to merge 5 commits into
Open
Changes and improvements on rule-based Filipino phonemizer#2144UtaUtaUtau wants to merge 5 commits into
UtaUtaUtau wants to merge 5 commits into
Conversation
Contributor
|
i like this change - signed nootsance |
Contributor
😭😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few improvements on the G2P to follow the behavior of the language more closely.
Main changes:
Extra:
|is now considered a bypass character for these extra rules. For example, tatsulok is phonemized as [t a ty u l o k] which is wrong, but can be corrected by bypassing the digraph check on the ts, which is done like so: tat|sulok.