BUILD: improved configure status reporting#1239
Conversation
|
| Filename | Overview |
|---|---|
| config/m4/cuda.m4 | improved NVML detection feedback and conditionally skips expensive NVCC gencode generation when TL CUDA unavailable |
| src/components/tl/cuda/configure.m4 | added detailed status messages but contains critical AS_IF syntax error that will break autoconf |
|
/build |
dfda49b to
25e215f
Compare
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Signed-off-by: Ilya Kryukov <ikryukov@nvidia.com>
Signed-off-by: Ilya Kryukov <ikryukov@nvidia.com>
Signed-off-by: Ilya Kryukov <ikryukov@nvidia.com>
25e215f to
0ee0353
Compare
|
/build |
There was a problem hiding this comment.
Additional Comments (1)
-
src/components/tl/cuda/configure.m4, line 21-25 (link)syntax: incorrect
AS_IFsyntax - autoconf will not parse this correctlyAS_IFtakes 3 arguments: condition, then-action, else-action. this code attempts to chain multiple test conditions which is invalid m4 syntax. needs nestedAS_IFfor elif logicalso added quotes around variables to match codebase style in
config/m4/cuda.m4
2 files reviewed, 1 comment
What
Improved configuration process and detection
Example: vLLM image ships without nvml and it was hard to debug why the CUDA is not working + NVLS were enabled in that case
Why ?