Conversation
|
Yeah this is fine, good suggestion @k-yle 👍 I remember adding this in 8db1c1f mostly because Milos asked for it here #8305 (comment) I remember being weakly against the idea of having code that automatically references the dependencies in My opinion is still that urls like these should be updated manually (by a human) and with intention. |
| const v = parseVersion(nsiVersion); | ||
| const vMinor = `${v.major}.${v.minor}`; | ||
| const cdn = nsiCdnUrl.replace('{version}', vMinor); | ||
| const cdn = nsiCdnUrl.replace('{version}', nsiVersion); |
There was a problem hiding this comment.
I am trying to confirm that my test plan makes sense: it is executed at runtime, when user starts editing, right?
There was a problem hiding this comment.
yes, correct. We can check the browser's devtools to see if the correct version of NSI is loaded:
The released version of iD currently uses @7.0, this PR will change it to @~7.0 to exactly match the value in package.json
matkoniecz
left a comment
matkoniecz
left a comment
There was a problem hiding this comment.
NSI continues to work in my test
4 participants
When constructing a CDN URL for NSI assets, NSI's version number is parsed with "vparse", and then the semver-patch part is removed.
As far as I can tell, this extra parsing is not required, because the jsdeliver CDN supports any semver syntax. None of the other assets do this extra parsing.
cc @bhousel, since this you added this because of #8305 (comment)