Skip to content

CORE-1094: Rex: Highlight box remains at the top of the page when scroll-highlighting text#2639

Merged
jomcarvajal merged 45 commits intomainfrom
CORE-1094
Jan 29, 2026
Merged

CORE-1094: Rex: Highlight box remains at the top of the page when scroll-highlighting text#2639
jomcarvajal merged 45 commits intomainfrom
CORE-1094

Conversation

@jomcarvajal
Copy link
Copy Markdown
Contributor

@jomcarvajal jomcarvajal commented Dec 31, 2025

@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-49jegbwirgkn December 31, 2025 15:04 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-mnnde0hhy3bf December 31, 2025 16:04 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-14obmatduvcu December 31, 2025 17:58 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-ehtqsm1zj4ow December 31, 2025 18:46 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-fo3efpoo9ity December 31, 2025 19:00 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-core-1094-9voubz8aan2q December 31, 2025 19:50 Inactive
@jomcarvajal jomcarvajal marked this pull request as ready for review January 8, 2026 16:21
@jomcarvajal jomcarvajal requested a review from a team as a code owner January 8, 2026 16:21
Copy link
Copy Markdown
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased and added a couple of small commits (explained in my comments).
I'm finding that when I extend my selection forward, the instruction box moves down, but when I extend upward (by shift-clicking before the start of the selection), it does not move.
If I select by dragging so that the page auto-scrolls while dragging, the box winds up a little below the frame (since the selected text goes right to the bottom of the viewport).
Do you think you can force the box into the viewport when the selection changes?

Comment thread src/app/content/highlights/components/cardUtils.ts Outdated
Comment thread src/typings/global.d.ts Outdated
@jomcarvajal
Copy link
Copy Markdown
Contributor Author

jomcarvajal commented Jan 9, 2026

I'm finding that when I extend my selection forward, the instruction box moves down, but when I extend upward (by shift-clicking before the start of the selection), it does not move.
If I select by dragging so that the page auto-scrolls while dragging, the box winds up a little below the frame (since the selected text goes right to the bottom of the viewport).
Do you think you can force the box into the viewport when the selection changes?

@RoyEJohnson I can't see what you saw. I'm able to move the box according my selection:

Screen.Recording.2026-01-09.at.9.25.58.AM.mov

Let me know if I misinterpreted your message .

PD: I fixed the the box position when showing bottom

@RoyEJohnson
Copy link
Copy Markdown
Contributor

RoyEJohnson commented Jan 12, 2026

This me in Chrome. It's apparently only when the screen is too narrow to position the box outside the text.

Screen.Recording.2026-01-12.at.4.23.48.PM.mov

Copy link
Copy Markdown
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little thing.

Comment thread src/app/content/highlights/components/cardStyles.ts Outdated
@jomcarvajal jomcarvajal merged commit 37da240 into main Jan 29, 2026
7 of 8 checks passed
@jomcarvajal jomcarvajal deleted the CORE-1094 branch January 29, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants