Skip to content

Commit a631014

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Fix volume backup show by name"
2 parents 4e8be5a + b6b1848 commit a631014

5 files changed

Lines changed: 11 additions & 6 deletions

File tree

openstackclient/tests/unit/volume/v2/test_volume_backup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ class TestBackupShow(volume_fakes.TestVolume):
544544
def setUp(self):
545545
super().setUp()
546546

547-
self.volume_sdk_client.get_backup.return_value = self.backup
547+
self.volume_sdk_client.find_backup.return_value = self.backup
548548
# Get the command object to test
549549
self.cmd = volume_backup.ShowVolumeBackup(self.app, None)
550550

@@ -554,7 +554,7 @@ def test_backup_show(self):
554554
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
555555

556556
columns, data = self.cmd.take_action(parsed_args)
557-
self.volume_sdk_client.get_backup.assert_called_with(self.backup.id)
557+
self.volume_sdk_client.find_backup.assert_called_with(self.backup.id)
558558

559559
self.assertEqual(self.columns, columns)
560560
self.assertEqual(self.data, data)

openstackclient/tests/unit/volume/v3/test_volume_backup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -879,7 +879,7 @@ class TestBackupShow(volume_fakes.TestVolume):
879879
def setUp(self):
880880
super().setUp()
881881

882-
self.volume_sdk_client.get_backup.return_value = self.backup
882+
self.volume_sdk_client.find_backup.return_value = self.backup
883883
# Get the command object to test
884884
self.cmd = volume_backup.ShowVolumeBackup(self.app, None)
885885

@@ -889,7 +889,7 @@ def test_backup_show(self):
889889
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
890890

891891
columns, data = self.cmd.take_action(parsed_args)
892-
self.volume_sdk_client.get_backup.assert_called_with(self.backup.id)
892+
self.volume_sdk_client.find_backup.assert_called_with(self.backup.id)
893893

894894
self.assertEqual(self.columns, columns)
895895
self.assertEqual(self.data, data)

openstackclient/volume/v2/volume_backup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ def get_parser(self, prog_name):
439439

440440
def take_action(self, parsed_args):
441441
volume_client = self.app.client_manager.sdk_connection.volume
442-
backup = volume_client.get_backup(parsed_args.backup)
442+
backup = volume_client.find_backup(parsed_args.backup)
443443
columns = (
444444
"availability_zone",
445445
"container",

openstackclient/volume/v3/volume_backup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ def get_parser(self, prog_name):
645645

646646
def take_action(self, parsed_args):
647647
volume_client = self.app.client_manager.sdk_connection.volume
648-
backup = volume_client.get_backup(parsed_args.backup)
648+
backup = volume_client.find_backup(parsed_args.backup)
649649
columns = (
650650
"availability_zone",
651651
"container",
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Fixed the ``openstack volume backup show`` command
5+
to show a backup by name.

0 commit comments

Comments
 (0)