Fix volume backup show by name

When we show a volume backup by name, it calls the get_backup
method in SDK which is only used for getting a backup by ID.
This patch modifies the approach to call find_backup method
which first tries the find by ID and then find by name logic
eventually returning the backup details.

Story: 2011234
Task: 51127
Change-Id: I926d8de9810fcf2e5335bbe35aaab15e1e36a5cb

Author: rajathere

openstackclient/tests/unit/volume/v2/test_volume_backup.py

@@ -544,7 +544,7 @@ class TestBackupShow(volume_fakes.TestVolume):
     def setUp(self):
         super().setUp()
 
-        self.volume_sdk_client.get_backup.return_value = self.backup
+        self.volume_sdk_client.find_backup.return_value = self.backup
         # Get the command object to test
         self.cmd = volume_backup.ShowVolumeBackup(self.app, None)
 
@@ -554,7 +554,7 @@ def test_backup_show(self):
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         columns, data = self.cmd.take_action(parsed_args)
-        self.volume_sdk_client.get_backup.assert_called_with(self.backup.id)
+        self.volume_sdk_client.find_backup.assert_called_with(self.backup.id)
 
         self.assertEqual(self.columns, columns)
         self.assertEqual(self.data, data)

openstackclient/tests/unit/volume/v3/test_volume_backup.py

@@ -876,7 +876,7 @@ class TestBackupShow(volume_fakes.TestVolume):
     def setUp(self):
         super().setUp()
 
-        self.volume_sdk_client.get_backup.return_value = self.backup
+        self.volume_sdk_client.find_backup.return_value = self.backup
         # Get the command object to test
         self.cmd = volume_backup.ShowVolumeBackup(self.app, None)
 
@@ -886,7 +886,7 @@ def test_backup_show(self):
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         columns, data = self.cmd.take_action(parsed_args)
-        self.volume_sdk_client.get_backup.assert_called_with(self.backup.id)
+        self.volume_sdk_client.find_backup.assert_called_with(self.backup.id)
 
         self.assertEqual(self.columns, columns)
         self.assertEqual(self.data, data)

openstackclient/volume/v2/volume_backup.py

@@ -439,7 +439,7 @@ def get_parser(self, prog_name):
 
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.sdk_connection.volume
-        backup = volume_client.get_backup(parsed_args.backup)
+        backup = volume_client.find_backup(parsed_args.backup)
         columns = (
             "availability_zone",
             "container",

openstackclient/volume/v3/volume_backup.py

@@ -643,7 +643,7 @@ def get_parser(self, prog_name):
 
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.sdk_connection.volume
-        backup = volume_client.get_backup(parsed_args.backup)
+        backup = volume_client.find_backup(parsed_args.backup)
         columns = (
             "availability_zone",
             "container",

releasenotes/notes/fix-show-backup-by-name-0759c55396be77a3.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fixed the ``openstack volume backup show`` command
+    to show a backup by name.