-
Notifications
You must be signed in to change notification settings - Fork 26
AppCred service operator support #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
22e9b75 to
7b386fd
Compare
7b386fd to
8a888f7
Compare
cschwede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline comment
controllers/swiftproxy_controller.go
Outdated
| secretRef, | ||
| os.GetRegion(), | ||
| transportURLString, | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an unresolved merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this up! Also I will soon push update to this PR anyway to reflect latest changes in keystone-operator
8a888f7 to
901b259
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Deydra71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
901b259 to
919c881
Compare
919c881 to
c74f3b4
Compare
c74f3b4 to
139670c
Compare
5d68e31 to
1bd11f0
Compare
1bd11f0 to
f201b1c
Compare
f201b1c to
6e97244
Compare
|
@Deydra71 Is the "do-not-merge/hold" label still valid or should this be merged? |
|
@cschwede It's still valid. We need to merge the openstack-k8s-operators/keystone-operator#567 first, which will happen soon. I'm asking for final reviews, and will talk about it at the soonest operator's roundtable. |
6e97244 to
357e648
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6cf6921b23044a5ea365e1f1b06cfa52 ❌ openstack-k8s-operators-content-provider FAILURE in 6m 08s |
357e648 to
dd2d646
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/203a18225364481c9f57bad6b434fb24 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 25s |
dd2d646 to
bde15d8
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4498829190ab41c3b20a8782390421df ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 30s |
bde15d8 to
2dc80b8
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1ae38461e58643e0ad225d0dbaf3b97e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 48s |
Jira: OSPRH-16627
This PR adds end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Swift operator, enabling Swift Proxy pods to use AC-based authentication when available.
API changes:
Adds an optional authentication field to the Swift PRoxy CR:
spec.auth.applicationCredentialSecret— name of the Secret that contains the Keystone Application Credential ID and Secret (AC_ID and AC_SECRET).Reconcile behavior:
Reads
spec.auth.applicationCredentialSecretAttempts to load AC_ID / AC_SECRET from the referenced Secret (via the Keystone helper).
If the secret is missing or incomplete, it falls back to password authentication (the AppCred auth is optional, not an error).
Once the AC Secret is ready with valid AC_ID and AC_SECRET fields, templates AC credentials into Swift PRoxy configuration
Computes hash of Secret contents and stores in configVars to trigger rolling updates when credentials rotate
Depends-On: openstack-k8s-operators/keystone-operator#567