-
Notifications
You must be signed in to change notification settings - Fork 143
[cifmw_cephadm] rework container registry credentials #3576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[cifmw_cephadm] rework container registry credentials #3576
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/576aa26d26aa4324940664287926d073 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 11s |
7843b68 to
2c28ea5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cd7c78601ff7460f8a1832e9c4e5cd78 ❌ openstack-k8s-operators-content-provider FAILURE in 4m 35s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/98ebd1f977984043addd3e0b6c0f2379 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 57s |
As default, use the already known set of variables which are meant to be used to store the URL and the credentials of the container registry. Also, do not pass the credentials to the cephadm command line, but hide them inside a configuration file, so that the credentials are not exposed in the ansible logs. The --registry-json argument has the same behavior of the combination of --registry-url/--registry-username/--registry-password which need to be passed at the same time anyway. Signed-off-by: Luigi Toscano <ltoscano@redhat.com>
8426aab to
4a6566e
Compare
As default, use the already known set of variables which are meant
to be used to store the URL and the credentials of the container
registry.
Also, do not pass the credentials to the cephadm command line,
but hide them inside a configuration file, so that the credentials
are not exposed in the ansible logs.
The --registry-json argument has the same behavior of the combination
of --registry-url/--registry-username/--registry-password which
need to be passed at the same time anyway.