ovn: Make "Prometheus" and "HW Offload" tests skippable.#1336
Merged
mkalcok merged 2 commits intoopenstack-charmers:stable/caracalfrom Jan 28, 2026
Merged
ovn: Make "Prometheus" and "HW Offload" tests skippable.#1336mkalcok merged 2 commits intoopenstack-charmers:stable/caracalfrom
mkalcok merged 2 commits intoopenstack-charmers:stable/caracalfrom
Conversation
mkalcok
added a commit
to canonical/charm-ovn-chassis
that referenced
this pull request
Jan 22, 2026
Func-test-pr: openstack-charmers/zaza-openstack-tests#1336 Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
mkalcok
added a commit
to canonical/charm-ovn-chassis
that referenced
this pull request
Jan 22, 2026
To run functional tests on GH runners, we need to use LXD juju substrate. However only Juju 3.1+ supports createing LXD VMs (need by the functional test). Rather than bringing Juju 3 support to stable/yoga branch of zaza and zaza-openstack-tests, it is easier for us to switch to stable/caracal branch that already supports Juju 3. Func-test-pr: openstack-charmers/zaza-openstack-tests#1336 Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
Contributor
Author
|
The change was tested and passed in this PR: canonical/charm-ovn-chassis#18 |
mkalcok
added a commit
to mkalcok/charm-ovn-dedicated-chassis
that referenced
this pull request
Jan 22, 2026
To run functional tests on GH runners, we need to use LXD juju substrate. However only Juju 3.1+ supports createing LXD VMs (need by the functional test). Rather than bringing Juju 3 support to stable/yoga branch of zaza and zaza-openstack-tests, it is easier for us to switch to stable/caracal branch that already supports Juju 3. Func-test-pr: openstack-charmers/zaza-openstack-tests#1336 Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
When env. variable 'TEST_SKIP_PROMETHEUS' is exported, the prometheus exporter test is skipped. This allows older releases of OVN charms to use stable/caracal branch of zaza-openstack-tests and benefit from the Juju3 support. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
When env. variable 'TEST_SKIP_HW_OFFLOAD' is exported, the Hardware Offload test is skipped. This allows older releases of ovn-dedicated-chassis charm, which lack the HW offload support, to use stable/caracal branch of zaza-openstack-tests and benefit from the Juju3 support. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
mkalcok
force-pushed
the
optional-prometheus
branch
from
0211bc4 to
da8b170
Compare
mkalcok
added a commit
to mkalcok/charm-ovn-dedicated-chassis
that referenced
this pull request
Jan 26, 2026
To run functional tests on GH runners, we need to use LXD juju substrate. However only Juju 3.1+ supports createing LXD VMs (need by the functional test). Rather than bringing Juju 3 support to stable/yoga branch of zaza and zaza-openstack-tests, it is easier for us to switch to stable/caracal branch that already supports Juju 3. Func-test-pr: openstack-charmers/zaza-openstack-tests#1336 Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
mkalcok
changed the title
fnordahl
approved these changes
Jan 28, 2026
Contributor
fnordahl
left a comment
fnordahl
left a comment
There was a problem hiding this comment.
Seems like a reasonable compromise, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use GH runners for functional tests of OVN chassis charms, we need the support for LXD VMs in Juju. This feature is supported since 3.1, but unfortunately,
zazaandzaza-openstack-testsinstable/yogabranch don't support Juju3.A solution for
22.03releases ofovn-chassisandovn-dedicated-chassis, which until now used zazastable/yoga, is to upgrade zaza tostable/caracal. This works fine in general and brings us a lot of fixes that were already backported to this branch, but we need to make couple tests optional, because the functionality is not present in22.03version of charms. Optional tests are controlled via environment variables.TEST_SKIP_PROMETHEUSskips test for reachability of prometheus exporterTEST_SKIP_HW_OFFLOADskips test for "Hardware offload"