This repository was archived by the owner on Jan 21, 2021. It is now read-only.
Open
Conversation
|
@maimoonak @ahmedihs could you review this and merge if it OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed setting up error notification via mail
We are currently forwarding all the mails to opensrp@gmail.com account, which we can configure it to relay the notification to all openers developers, i'll share the password for the account on hip chat.
Changes:
pom.xml => added mail dependency
assets/config/log4j.xml => added smtp configs
The other changes are trivial e.g just adding logging statement on the catch block so that the error can be sent
NB: all developers should now use logger.error() whenever an error occurs in order to send out the mail notification.