Fix synchronization issue with android notification #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasttvo
commented
Oct 17, 2025
| NoWifi, NoInternet, Ok; | ||
|
|
||
| companion object { | ||
| fun fetch(context: Context, wifiOnly: Boolean): Connectivity { |
Collaborator
Author
There was a problem hiding this comment.
moved from UploadWorker.ts no logical change
thomasttvo
commented
Oct 17, 2025
| } | ||
|
|
||
| // builds the notification required to enable Foreground mode | ||
| fun build(context: Context): Notification { |
Collaborator
Author
There was a problem hiding this comment.
moved from UploadWorker.ts. Not much has changed except for val wifiOnly = getActiveUpload()?.wifiOnly ?: false
thomasttvo
commented
Oct 17, 2025
| if (this.activeUpload?.id == upload.id) this.activeUpload = null | ||
| } | ||
|
|
||
| fun setOptions(opts: ReadableMap) { |
Collaborator
Author
There was a problem hiding this comment.
these options are moved over from the Upload class, so they are now global options instead of per-Upload options
dhruv-dangi-openspace
requested changes
Oct 30, 2025
| setProgress(undefined); | ||
| console.log('Upload error!', err); | ||
| }); | ||
| for (let i = 0; i < 100; i++) { |
There was a problem hiding this comment.
Can we add a comment explaining the magic number 100 and why we have to perform Upload.startUpload 100 times?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a non-wifi-only upload is running and a wifi-only one is started but hasn't got its turn to run yet, it may still overwrite the shared notification with its own "wifiOnly" preferences.
This PR solves the problem by centralizing notification management into an
UploadNotificationsingleton and have it be aware of the active uploadNote
Moves notification config to a one-time Android initialize() and centralizes progress/connection UI via UploadNotification; updates worker logic and JS/TS types accordingly.
UploadNotificationsingleton to build/update a shared notification, track active upload, and handle titles based on connectivity.Connectivity.fetchfor validated internet/Wi‑Fi checks; remove inline connectivity logic fromUploadWorker.UploadWorkernow usesUploadNotificationfor foreground info and progress updates; removes per-upload notification building and validation helpers.MissingOptionExceptioninto its own class.Upload.UploaderModule.initialize(options)to set notification options.initialize(options: AndroidInitializationOptions);startUploadno longer acceptsandroidoptions.AndroidInitializationOptionstype; updateUploadOptionsand type declarations.Written by Cursor Bugbot for commit 99c0f34. Configure here.