forked from elliottkember/react-native-background-upload
-
Notifications
You must be signed in to change notification settings - Fork 5
Android Upload v2 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thomasttvo
wants to merge
31
commits into
master
Choose a base branch
from
thomas/android-upload-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # android/src/main/java/com/vydia/RNUploader/UploaderModule.kt
Comment on lines
66
to
68
| workManager | ||
| .beginUniqueWork(WORKER_ID, ExistingWorkPolicy.KEEP, request) | ||
| .enqueue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the effective change here is using WORKER_ID to beginUniqueWork instead of upload.id which would create a new unique work for each upload? 👏👏
Does a WORKER_ID worker just pulls from the UploadQueue? Or is the UploadQueue just for keeping track and getting stats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC, TBD
Note
Revamps Android upload with a queued engine and centralized notifications, introduces initialize(), removes chunking API, updates JS types and example app, and adds protobuf/datastore build setup.
UploadQueuefor serial queued uploads, overall progress, and completion tracking; refactorUploadWorkerto process queue, throttle progress, and update notifications directly.NotificationConfigsset viainitialize(...); foreground info/notification building centralized; progress now usesUploadQueue.progressPercentage().okhttpUploadnow returnsUploadResponse(code, message, headers, body);EventReporter.successconsumesUploadResponse.ChunkUtils.kt, JSchunkFile), and per-upload Android notification fields fromUpload/start options.androidx.datastore:datastore.Upload.initialize(options: AndroidInitializationOptions);startUploadno longer acceptsandroidoptions.AndroidInitializationOptions; removeandroidfromUploadOptions; removechunkFileexports.minSdkto 24.chunkFilemethod from native module (no functional upload changes).Written by Cursor Bugbot for commit 1f3a08e. This will update automatically on new commits. Configure here.