Fixed the layout and navbar in mobile view#704
Closed
abhi-the-dumb wants to merge 1 commit intoopensource-society:mainfrom
Closed
Fixed the layout and navbar in mobile view#704abhi-the-dumb wants to merge 1 commit intoopensource-society:mainfrom
abhi-the-dumb wants to merge 1 commit intoopensource-society:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Author
|
Hi, I see your codebase i think the css needs to be split into footer.css , header.css, navbar.css the main.css is too big and is not easily readible for understnading the codebase. Would you like me to open an issue on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI,
Reduced redudant css code which is conflicting with bootstrap. Actually the css and bootstrap are conflicting with each other. So pls try to keep the css to a minimum and try to use bootstrap wherever possible or there will be just a mess of files with redudant code.