Skip to content

Conversation

@apella12
Copy link

@apella12 apella12 commented Apr 8, 2023

Added alarm_cold & alarm_humidity to align with merged PR. Also because file did not match the current dropdown, added or deleted channels to match. Left channels with no match in the binding alone for now.

Added alarm_cold & alarm_humidity to align with merged PR.  Also because file did not match the current dropdown, added or deleted channels to match.  Left channels with no match in the binding alone for now.

Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
@cdjackson
Copy link
Contributor

Thanks. This is not in any way hooked up to the website version which has changed considerably over the years. I will need to find some time to try and reconcile this.

@bwosborne2
Copy link
Collaborator

I thought this project died a while ago.

@cdjackson
Copy link
Contributor

Not at all. This is used by openhab for starters, and also other OSH users.

@apella12
Copy link
Author

apella12 commented Apr 8, 2023

I suspected a disconnect when the dropdown (Endpoint:Channel) while creating a device did not match the github file. I know you are busy. All I really need is alarm_cold & alarm_humidity to be added to the dropdown. They are part of the binding (alarmConverter) since PR #1850, but are not available for use when creating a device. The other changes I made were just for consistency. Typical type A behavior ;-)

@cdjackson
Copy link
Contributor

Ok, thanks for looking at this. As a suggestion, how about I update master branch with what's actually on the website, and then you rebase this (if needed) on that. I think that's best as we then get back in sync - sorry - it's a bit more work for you (maybe).

@apella12
Copy link
Author

apella12 commented Apr 9, 2023

No problem with your suggestion. I don't think it will be that difficult. I have already compared the channels in the dropdown that appears when creating the device a couple of times. Worst case I'll delete the fork (and the PRs) and start over (but I have saved my edits outside github). I can fix the logviewer too if you update that file also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants