Delete unused clavicle geometry#82
Open
jimmyDunne wants to merge 1 commit intoremove_simbody_suffixfrom
Open
Conversation
Member
|
This has been open for a year and half, any reason to keep/merge or just close @jimmyDunne Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused clavicles. Models not in the repo, that have arms, typically use the hat_rib_clav.vtp geometry. There may be a case to add the deleted geometry files to a folder for depreciated geometry in case they could be useful in the future. If no review in a week, I will merge.