Minor updates to metabolic example package#105
Merged
chrisdembia merged 2 commits intomasterfrom Nov 11, 2018
Merged
Conversation
chrisdembia
approved these changes
Nov 11, 2018
Member
chrisdembia
left a comment
There was a problem hiding this comment.
I pushed a commit to fix indentation in CMakeLists.txt.
We might have fixed the paths issue such that the files no longer need to be rearranged (opensim-org/opensim-core#2366), though I am still fine with this new organization.
It would be good to also delete the duplicate scripts from the GUI (in a separate PR).
Member
Author
|
You're the best!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR addresses address' #102 with a minimum set of changes that allows the Metabolics tutorial to be completed. I am performing a tutorial refactoring in #104, but those changes won't be finished before the release.
Changes made
Cmake changes for building the file tree for the example. Models, tutorial files, and data have been placed such that the example can be run without error. The CMC setup files, External Loads setup file, and experimental data are in the top directory because of issues OpenSim has with paths to files.
Updats to the scripts were performed in #103
Tests that I have completed
To be completed